buildresult: replace serialization with an enum to simplify compatibility #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
commented
Aug 10, 2018
ofborg/src/message/buildresult.rs
Outdated
| // as long as we can translate all enum variants. | ||
| match self { | ||
| BuildResult::Legacy { repo, pr, system, output, attempt_id, request_id, attempted_attrs, skipped_attrs, .. } => | ||
| LegacyBuildResult { |
There was a problem hiding this comment.
I can also clean this part up a bit if you prefer, didn't want to make a huge pr.
LnL7
commented
Aug 10, 2018
| } | ||
|
|
||
| #[test] | ||
| pub fn test_no_status_compatibility() { |
There was a problem hiding this comment.
This is tested by the the serialization now.
LnL7
force-pushed
the
build-result-enum
branch
2 times, most recently
from
96487bc
to
49c8482
Compare
|
I added a V1 format with tagging and cleaned up the usage a bit. |
…lity This separates the serialized BuildResult type that requires backwards compatibility to avoid breaking results received from older builders and the LegacyBuildResult type use internally.
This drops the old build success format and makes the request_id mandatory (was optional for compatibility).
With this builders should start producing messages that include a version tag.
LnL7
force-pushed
the
build-result-enum
branch
from
49c8482
to
758c94e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the serialized BuildResult type that requires backwards
compatibility to avoid breaking results received from older builders and
the LegacyBuildResult type use internally.