-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: Disable firefox vlc 1803 #44931
Conversation
Fixes NixOS#44930 (cherry picked from commit 3107b4f)
Well, the error message is easy to get rid of. The real question is whether the plugin would really work with that fix. |
I was under the impression that NPAPI plugins didn't work at all with such recent versions of Firefox? If that's wrong, then this PR is also wrong. :-P |
Correct (Flash has an exception). It stopped in 52, and that's the oldest ESR we have. There might be more such cases in the wrapper, even on master. |
OK, since our ESR version reaches that far back, I'll close this. Thanks for noticing. :) |
To be clear, the oldest one we have (52) should be without NPAPI support already (except Flash). |
Oh, off-by-1 misunderstanding. 😆 |
I suspect Mozilla specifically wanted to get rid of it in the ESR version, due to NPAPI being a security nightmare. |
(cherry picked from commit 490e6fc)
I just wonder if these obsoleted nixpkgs config options should be just silently ignored (the current code does that) or if there should be at least a warning printed. |
Do we have any infrastructure to support that at all? We'd need some way to actually evaluate possibly-existing-but-no-longer-active configuration and throw an error on that. |
I meant simply having the wrapper check non-existence of those options instead of using them. |
It wouldn't work anyway, even before 18.03 started.
Motivation for this change
Fixes #44930
Obsolete option
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)