Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Disable firefox vlc 1803 #44931

Merged
merged 2 commits into from Aug 24, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 12, 2018

Motivation for this change

Fixes #44930
Obsolete option

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Fixes NixOS#44930
(cherry picked from commit 3107b4f)
@vcunat vcunat changed the title Backport: Disable firefox vnc 1803 Backport: Disable firefox vlc 1803 Aug 12, 2018
@vcunat
Copy link
Member

vcunat commented Aug 12, 2018

Well, the error message is easy to get rid of. The real question is whether the plugin would really work with that fix.

@srhb
Copy link
Contributor Author

srhb commented Aug 12, 2018

I was under the impression that NPAPI plugins didn't work at all with such recent versions of Firefox? If that's wrong, then this PR is also wrong. :-P

@vcunat
Copy link
Member

vcunat commented Aug 12, 2018

Correct (Flash has an exception). It stopped in 52, and that's the oldest ESR we have. There might be more such cases in the wrapper, even on master.

@srhb
Copy link
Contributor Author

srhb commented Aug 12, 2018

OK, since our ESR version reaches that far back, I'll close this. Thanks for noticing. :)

@srhb srhb closed this Aug 12, 2018
@vcunat vcunat reopened this Aug 12, 2018
@vcunat
Copy link
Member

vcunat commented Aug 12, 2018

To be clear, the oldest one we have (52) should be without NPAPI support already (except Flash).

@srhb
Copy link
Contributor Author

srhb commented Aug 12, 2018

Oh, off-by-1 misunderstanding. 😆

@vcunat
Copy link
Member

vcunat commented Aug 12, 2018

I suspect Mozilla specifically wanted to get rid of it in the ESR version, due to NPAPI being a security nightmare.

@vcunat
Copy link
Member

vcunat commented Aug 12, 2018

I just wonder if these obsoleted nixpkgs config options should be just silently ignored (the current code does that) or if there should be at least a warning printed.

@srhb
Copy link
Contributor Author

srhb commented Aug 12, 2018

Do we have any infrastructure to support that at all? We'd need some way to actually evaluate possibly-existing-but-no-longer-active configuration and throw an error on that.

@vcunat
Copy link
Member

vcunat commented Aug 12, 2018

I meant simply having the wrapper check non-existence of those options instead of using them.

@vcunat vcunat merged commit febd4af into NixOS:release-18.03 Aug 24, 2018
vcunat added a commit that referenced this pull request Aug 24, 2018
It wouldn't work anyway, even before 18.03 started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants