Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dlang update #44904

Merged
merged 4 commits into from Aug 16, 2018
Merged

Dlang update #44904

merged 4 commits into from Aug 16, 2018

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change

Bump versions for various dlang related packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Disabled tests on Darwin for now
Needed to switch to ldc as bootstrap compiler to fix the compilation
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dmd, dtools, dub, ldc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dmd, dtools, dub, ldc

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/24smil6pamjwqxg5a85ykg60mfsmd6rv-dubUnittests-1.10.0
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/24smil6pamjwqxg5a85ykg60mfsmd6rv-dubUnittests-1.10.0
checking for references to /build in /nix/store/24smil6pamjwqxg5a85ykg60mfsmd6rv-dubUnittests-1.10.0...
building '/nix/store/bpj900446fpr65dkm58b2b3b4crpcsnn-dub-1.10.0.drv'...
installing
/nix/store/j4fj8vb3805k4lff57nj9dfb44j31as1-dmd-2.081.1
/nix/store/zwzj9ivr1z0k755bwn8wg9crcwm2zph8-dtools-2.081.1
/nix/store/sqr942fy3dgnxwmk1lxjkjfxa8jrn9x7-dub-1.10.0
/nix/store/myqkxw4miya3l2l720vrmzdrqgmzlkla-ldc-1.10.0

@ThomasMader
Copy link
Contributor Author

Let's try to get it to build on Darwin too.

@GrahamcOfBorg build ldc dmd dtools dub

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ldc, dmd, dtools, dub

Partial log (click to expand)

/nix/store/myqkxw4miya3l2l720vrmzdrqgmzlkla-ldc-1.10.0
/nix/store/j4fj8vb3805k4lff57nj9dfb44j31as1-dmd-2.081.1
/nix/store/zwzj9ivr1z0k755bwn8wg9crcwm2zph8-dtools-2.081.1
/nix/store/sqr942fy3dgnxwmk1lxjkjfxa8jrn9x7-dub-1.10.0

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ldc, dmd, dtools, dub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@ThomasMader
Copy link
Contributor Author

Don't know why it's not building on Darwin but I tested it on my machine without any problems. So this is ready to be merged.

@Mic92
Copy link
Member

Mic92 commented Aug 15, 2018

@GrahamcOfBorg build ldc dmd dtools dub

@Mic92
Copy link
Member

Mic92 commented Aug 15, 2018

darwin is limited to trusted user since we do not have a sandbox on macOS.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ldc, dmd, dtools, dub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ldc, dmd, dtools, dub

Partial log (click to expand)

   --test-compilers=/nix/store/1pq09qj6kdp6x32nvcwrr7bcdz3kw024-dmd-2.081.1/bin/dmd \

/nix/store/1pq09qj6kdp6x32nvcwrr7bcdz3kw024-dmd-2.081.1/bin/dmd -I../druntime/import -I../phobos -L-L../phobos/generated/osx/release/64 -m64 -fPIC -w -de -unittest -main -run rdmd.d
ld: warning: directory not found for option '-L../phobos/generated/osx/release/64'
/var/tmp/dmd_run0RKIdN: Permission denied
core.thread.ThreadError@core/thread.d(3200): Unable to load thread state
----------------
make: *** [posix.mak:124: test_rdmd] Error 255
builder for '/nix/store/qiasp4wlpdhfg908vlxby5nkb553rlkg-dtools-2.081.1.drv' failed with exit code 2
error: build of '/nix/store/qiasp4wlpdhfg908vlxby5nkb553rlkg-dtools-2.081.1.drv' failed

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: ldc, dmd, dtools, dub

Partial log (click to expand)


Total Test time (real) =  42.98 sec
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q6vnl3bcz52g7yyvmq4rnhwaj5c3nr63-ldcUnittests-1.10.0
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/q6vnl3bcz52g7yyvmq4rnhwaj5c3nr63-ldcUnittests-1.10.0
checking for references to /build in /nix/store/q6vnl3bcz52g7yyvmq4rnhwaj5c3nr63-ldcUnittests-1.10.0...
warning: path '/nix/store/q6vnl3bcz52g7yyvmq4rnhwaj5c3nr63-ldcUnittests-1.10.0' claims to be content-addressed but isn't
error: unexpected end-of-file

@ThomasMader
Copy link
Contributor Author

For the Darwin build we once again have the problem with the shared tmp dirs. See #41099 (comment) for reference.

Why the Linux build was done again is funny, the previous build package must have been erased from the binary cache or something because my second build run just used a cached build.

Nevertheless this problem already occured and I opened NixOS/nix#2155 but closed it because it seemed to be fixed in nix 2.0.2.
18.03 comes with 2.0.4 now so it's either a regression or the ofBorg build machine has an older nix version or it is something totally different.

Has someone access to that very same build machine to check the nix version?

@Mic92
Copy link
Member

Mic92 commented Aug 16, 2018

The build before was executed on a different machine. I would ignore this for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants