lightdm-enso-os-greeter: init at 0.2.1 #44920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eadwu
commented
Aug 12, 2018
| ./lightdm-greeters/mini.nix | ||
| ./lightdm-greeters/gtk.nix |
There was a problem hiding this comment.
Not sure if I interpreted the comment here wrong, from what I understand, gtk.nix should always be on the bottom?
There was a problem hiding this comment.
With #44926, it doesn't seem to be a problem, so I'll just remove the reordering.
eadwu
commented
Aug 12, 2018
| @@ -0,0 +1,72 @@ | |||
| { stdenv, fetchgit, pkgconfig | |||
| , dbus, pcre, epoxy, libXdmcp, at-spi2-core, libxklavier, libxkbcommon, libpthreadstubs | |||
There was a problem hiding this comment.
These packages (2nd line) are just to resolve warnings(?) raised by pkgconfig. Seems to compile fine without them.
eadwu
force-pushed
the
init/lightdm-enso-os-greeter
branch
from
51344d8
to
84338fc
Compare
eadwu
force-pushed
the
init/lightdm-enso-os-greeter
branch
from
84338fc
to
71a52c4
Compare
mnacamura
reviewed
Aug 12, 2018
|
|
||
| greeters = { | ||
| gtk = { | ||
| enable = false; |
There was a problem hiding this comment.
enable = mkDefault false; is better I guess.
| ''; | ||
| }; | ||
|
|
||
| wallpaper = mkOption { |
There was a problem hiding this comment.
This option might be redundant as we already have ldmcfg.background?
eadwu
force-pushed
the
init/lightdm-enso-os-greeter
branch
from
71a52c4
to
1ee9932
Compare
eadwu
force-pushed
the
init/lightdm-enso-os-greeter
branch
from
1ee9932
to
2d1ecc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Gtk greeter was too plain for me and couldn't get lightdm-webkit2-greeter to work so the next best thing.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)