Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates pywal to version 3.1.0 #44924

Merged
merged 1 commit into from Aug 12, 2018
Merged

Updates pywal to version 3.1.0 #44924

merged 1 commit into from Aug 12, 2018

Conversation

0x6C38
Copy link
Contributor

@0x6C38 0x6C38 commented Aug 12, 2018 •
edited by dotlambda

Motivation for this change

Fixes #44925.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@NixOS NixOS deleted a comment from 0x6C38 Aug 12, 2018
@dotlambda
Copy link
Member

dotlambda commented Aug 12, 2018 •
edited

@Mr-SD Please change the commit message to pywal: 2.0.5 -> 3.1.0

@dotlambda
Copy link
Member

dotlambda commented Aug 12, 2018 •
edited

@GrahamcOfBorg build pywal

@NixOS NixOS deleted a comment from GrahamcOfBorg Aug 12, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Aug 12, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Aug 12, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pywal

Partial log (click to expand)

> Create special escape sequence with alpha. ... ok
test_all_templates (tests.test_export.TestExportColors)
> Test substitutions in template file. ... ok
test_css_template (tests.test_export.TestExportColors)
> Test substitutions in template file (css). ... ok

----------------------------------------------------------------------
Ran 29 tests in 0.147s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pywal

Partial log (click to expand)

test_all_templates (tests.test_export.TestExportColors)
> Test substitutions in template file. ... ok
test_css_template (tests.test_export.TestExportColors)
> Test substitutions in template file (css). ... ok

----------------------------------------------------------------------
Ran 29 tests in 0.492s

OK
/nix/store/kycr5lji3cm2v84a52zxl7j2f7qbj6s0-pywal-3.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pywal

Partial log (click to expand)

> Generate a colorscheme. ... ok
test_gen_colors_fail (tests.test_colors.TestGenColors)
> Generate a colorscheme and fail. ... ERROR:root:Imagemagick couldn't generate a palette.
ERROR:root:Try a different image or backend.
ok

----------------------------------------------------------------------
Ran 29 tests in 0.539s

OK

@0x6C38 0x6C38 changed the title Updates pywal to version 3.1.0 pywal: 2.0.5 -> 3.1.0 Aug 12, 2018
@0x6C38 0x6C38 changed the title pywal: 2.0.5 -> 3.1.0 Updates pywal to version 3.1.0 Aug 12, 2018
@0x6C38
Copy link
Contributor Author

0x6C38 commented Aug 12, 2018

@dotlambda Done

@dotlambda dotlambda merged commit 7c66a90 into NixOS:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pywal is outdated
4 participants
@0x6C38 @dotlambda @GrahamcOfBorg @Janik-Haag