New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to override VSCode version #44897
Conversation
Isn't this possible through |
It is possible, but the user will then need to hard-code the url from |
Sorry, I don't understand the motivation here. The normal way to override a version in nixpkgs is exactly
If this is also possible in this package, why do we need to make it possible using |
Sure, let me expand on this a bit! It's true that it is possible to override everything, including the source code, using What I am getting at is that it would be really convenient, for one off overrides, to be able to say |
@matklad I understand your reasoning and motivation now. Here's my concern, which you already summarized (and maybe you can reuse that or link the discussion and I'll add it myself:) If we were to add a section on overriding package versions in the nixpkgs manual (which we really ought to,) your changes would imply that it would sound like the following: "Check if the package accepts version and sha256 attributes. If so, use pkg.override. Otherwise, use pkg.overrideAttrs and override the src attribute" I'm not a fan of this conditional. I think it should be a uniform process. |
Started a thread: https://discourse.nixos.org/t/should-version-and-sha256-attributes-of-packages-be-easily-overridable/658 Closing this as it's clear that it's more of a global policy question rather than a particular single package issue. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
Make
version
,channel
andhash
of VS Code derivation overrideable, so that it's easier to use the nightly versions. See https://discourse.nixos.org/t/best-way-to-install-pre-release-versions-of-software/651Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)