Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant flootty package and update the correct package #44889

Merged
merged 2 commits into from Aug 12, 2018
Merged

Remove redundant flootty package and update the correct package #44889

merged 2 commits into from Aug 12, 2018

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Aug 11, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Enzime Enzime requested a review from FRidh as a code owner August 11, 2018 05:40
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.flootty python3.pkgs.flootty

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.flootty, python3.pkgs.flootty

Partial log (click to expand)

Cannot nix-instantiate `python2.pkgs.flootty' because:
error: attribute 'flootty' in selection path 'python2.pkgs.flootty' not found

Cannot nix-instantiate `python3.pkgs.flootty' because:
error: attribute 'flootty' in selection path 'python3.pkgs.flootty' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.flootty, python3.pkgs.flootty

Partial log (click to expand)

Cannot nix-instantiate `python2.pkgs.flootty' because:
error: attribute 'flootty' in selection path 'python2.pkgs.flootty' not found

Cannot nix-instantiate `python3.pkgs.flootty' because:
error: attribute 'flootty' in selection path 'python3.pkgs.flootty' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.flootty, python3.pkgs.flootty

Partial log (click to expand)

Cannot nix-instantiate `python2.pkgs.flootty' because:
error: attribute 'flootty' in selection path 'python2.pkgs.flootty' not found

Cannot nix-instantiate `python3.pkgs.flootty' because:
error: attribute 'flootty' in selection path 'python3.pkgs.flootty' not found

@dotlambda
Copy link
Member

@GrahamcOfBorg build flootty

@Enzime Can please try replacing python by python3 while you're at it?

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flootty

Partial log (click to expand)

writing entry points to Flootty.egg-info/entry_points.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/x8z3ka36dzcyziv0cwrlbvp3pfgyfcn6-Flootty-3.2.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: flootty

Partial log (click to expand)

writing entry points to Flootty.egg-info/entry_points.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/s5gjmlj5s4y5kivkgxb62h1i1wcahkc0-Flootty-3.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flootty

Partial log (click to expand)

writing entry points to Flootty.egg-info/entry_points.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/03gclr7vm6v05iaaw2fd173y4dngk3gz-Flootty-3.2.2

@Enzime
Copy link
Member Author

Enzime commented Aug 12, 2018

@dotlambda done :)

@dotlambda
Copy link
Member

@GrahamcOfBorg build flootty

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: flootty

Partial log (click to expand)

writing top-level names to Flootty.egg-info/top_level.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
/nix/store/pl197l0w7msw4npj85nyjw6dyif1ws5f-Flootty-3.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flootty

Partial log (click to expand)

writing top-level names to Flootty.egg-info/top_level.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/1vd7m7q42h3qgx067iwdrnd1jjyp5mdl-Flootty-3.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flootty

Partial log (click to expand)

writing top-level names to Flootty.egg-info/top_level.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ks7mwxa4hyj005f3yg0n2bc7zv6ybhyj-Flootty-3.2.2

@dotlambda dotlambda merged commit 4af9ee4 into NixOS:master Aug 12, 2018
@Enzime Enzime deleted the update/flootty branch August 14, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enzime @dotlambda @GrahamcOfBorg