Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/CODEOWNERS: Add myself as for some stdenv stuff #44908

Merged
merged 1 commit into from Aug 11, 2018
Merged

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Aug 11, 2018

Motivation for this change
  • pkgs/stdenv/cross is a small, low-churn, subtree. But hopefully this indicates people can bug me generally about cross things.
  • /pkgs/stdenv/generic because it was heavily modified as part of the cross work. I'd love for someone else to join me on this one!
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 merged commit af36123 into master Aug 11, 2018
@Ericson2314 Ericson2314 deleted the codeowners branch September 15, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants