Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doing: init at 1.0.10pre #44034

Merged
merged 1 commit into from Aug 2, 2018
Merged

doing: init at 1.0.10pre #44034

merged 1 commit into from Aug 2, 2018

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Jul 23, 2018

Motivation for this change

Adds the doing application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Jul 24, 2018
View reviewed changes
pkgs/applications/misc/doing/default.nix Outdated
# Bundix:
# nix-shell -p bundix zlib
bundlerEnv rec {
name = pname + "-" + version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed because bundlerEnv will handle it.

@ryantm
Copy link
Member

ryantm commented Jul 24, 2018

It looks like this is missing an addition to all-packages.nix, or how do you build this application?

@ktf
Copy link
Contributor Author

ktf commented Jul 24, 2018

right... I've it in my own overlay... Will fix it...

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

@GrahamcOfBorg build doing

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: doing

Partial log (click to expand)

1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a954aq0pkq16h7mn1bdj6gqy6pw541fg-ruby2.4.4-doing-1.0.10pre
patching script interpreter paths in /nix/store/a954aq0pkq16h7mn1bdj6gqy6pw541fg-ruby2.4.4-doing-1.0.10pre
/nix/store/a954aq0pkq16h7mn1bdj6gqy6pw541fg-ruby2.4.4-doing-1.0.10pre/lib/ruby/gems/2.4.0/gems/doing-1.0.10pre/lib/doing/wwid.rb: interpreter directive changed from "/usr/bin/ruby" to "/nix/store/qzixvnzdq18g3jmc9yb1jk25bc9z8q91-ruby-2.4.4/bin/ruby"
/nix/store/a954aq0pkq16h7mn1bdj6gqy6pw541fg-ruby2.4.4-doing-1.0.10pre/lib/ruby/gems/2.4.0/gems/doing-1.0.10pre/bin/doing: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/qzixvnzdq18g3jmc9yb1jk25bc9z8q91-ruby-2.4.4/bin/ruby"
checking for references to /build in /nix/store/a954aq0pkq16h7mn1bdj6gqy6pw541fg-ruby2.4.4-doing-1.0.10pre...
building '/nix/store/3vd46fcs4dgy9h3pp3cc3dj3vb2zva2z-doing-1.0.10pre.drv'...
created 31 symlinks in user environment
/nix/store/nmjgn9jdkqlkw3l6n3ci38f18d5pjy5h-doing-1.0.10pre

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: doing

Partial log (click to expand)

  Gem home: /nix/store/1k9b5wbnfgg7nz50hd01yxicijsm4929-ruby2.4.4-doing-1.0.10pre/lib/ruby/gems/2.4.0
Successfully installed doing-1.0.10pre
1 gem installed
post-installation fixup
patching script interpreter paths in /nix/store/1k9b5wbnfgg7nz50hd01yxicijsm4929-ruby2.4.4-doing-1.0.10pre
/nix/store/1k9b5wbnfgg7nz50hd01yxicijsm4929-ruby2.4.4-doing-1.0.10pre/lib/ruby/gems/2.4.0/gems/doing-1.0.10pre/bin/doing: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/kgpda4f3mff0m5n5a6c417zxvizd7l1p-ruby-2.4.4/bin/ruby"
/nix/store/1k9b5wbnfgg7nz50hd01yxicijsm4929-ruby2.4.4-doing-1.0.10pre/lib/ruby/gems/2.4.0/gems/doing-1.0.10pre/lib/doing/wwid.rb: interpreter directive changed from "/usr/bin/ruby" to "/nix/store/kgpda4f3mff0m5n5a6c417zxvizd7l1p-ruby-2.4.4/bin/ruby"
building '/nix/store/9jz80y5k163k22jlns2006q227h6zmvm-doing-1.0.10pre.drv'...
created 31 symlinks in user environment
/nix/store/s1hiih27s94rkd8j4da86m1qr0kis3cs-doing-1.0.10pre

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: doing

Partial log (click to expand)

1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zrjs7xmbvh5hmsd2bizpify9dfrzq50j-ruby2.4.4-doing-1.0.10pre
patching script interpreter paths in /nix/store/zrjs7xmbvh5hmsd2bizpify9dfrzq50j-ruby2.4.4-doing-1.0.10pre
/nix/store/zrjs7xmbvh5hmsd2bizpify9dfrzq50j-ruby2.4.4-doing-1.0.10pre/lib/ruby/gems/2.4.0/gems/doing-1.0.10pre/lib/doing/wwid.rb: interpreter directive changed from "/usr/bin/ruby" to "/nix/store/syr8k8mhzi90nmqbz8jsnv0izihrfy6l-ruby-2.4.4/bin/ruby"
/nix/store/zrjs7xmbvh5hmsd2bizpify9dfrzq50j-ruby2.4.4-doing-1.0.10pre/lib/ruby/gems/2.4.0/gems/doing-1.0.10pre/bin/doing: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/syr8k8mhzi90nmqbz8jsnv0izihrfy6l-ruby-2.4.4/bin/ruby"
checking for references to /build in /nix/store/zrjs7xmbvh5hmsd2bizpify9dfrzq50j-ruby2.4.4-doing-1.0.10pre...
building '/nix/store/zxj5mw9cba4b06m03f10vgym9xhz1iby-doing-1.0.10pre.drv'...
created 31 symlinks in user environment
/nix/store/q17nsdw2g17yjqf0m8kw9sck08pbgipr-doing-1.0.10pre

xeji
xeji approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback was addressed. LGTM.

@xeji xeji merged commit ca7b17a into NixOS:master Aug 2, 2018
@ktf ktf deleted the add-doing branch August 2, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktf @ryantm @xeji @GrahamcOfBorg