Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: init ephemeral_port_reserve at v1.1.0 #44036

Closed
wants to merge 1 commit into from
Closed

python: init ephemeral_port_reserve at v1.1.0 #44036

wants to merge 1 commit into from

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Jul 23, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jb55
python: init ephemeral_port_reserve at v1.1.0
fa5ac50 
Signed-off-by: William Casarin <jb55@jb55.com>
@jb55 jb55 requested a review from FRidh as a code owner July 23, 2018 23:23
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python

Partial log (click to expand)

/nix/store/sa795spv9vxy8gwvaly3i04v1fx5c8kr-python-2.7.15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python

Partial log (click to expand)

/nix/store/azhdpcvzczk0h1xzmzzrwd2sc3mddm6s-python-2.7.15

ryantm
ryantm requested changes Jul 24, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to be "python.pkgs.ephemeral_port_reserve: init at 1.1.0"

@ryantm
Copy link
Member

ryantm commented Jul 24, 2018

@GrahamcOfBorg build python2.pkgs.ephemeral_port_reserve python3.pkgs.ephemeral_port_reserve

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.ephemeral_port_reserve, python3.pkgs.ephemeral_port_reserve

Partial log (click to expand)

reading manifest file 'ephemeral_port_reserve.egg-info/SOURCES.txt'
writing manifest file 'ephemeral_port_reserve.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/6pdqvwb3536vg1yivd1kyvv09ww3zwz4-python2.7-ephemeral_port_reserve-1.1.0
/nix/store/gnz3bwv9vj596jb8n11s0k9lg84aw4gx-python3.6-ephemeral_port_reserve-1.1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.ephemeral_port_reserve, python3.pkgs.ephemeral_port_reserve

Partial log (click to expand)

reading manifest file 'ephemeral_port_reserve.egg-info/SOURCES.txt'
writing manifest file 'ephemeral_port_reserve.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/glb5k075n8yimxwixfn0ghg0ajrqi28k-python2.7-ephemeral_port_reserve-1.1.0
/nix/store/lpd22n36c7f8nx6dvr9cgjgazi2dj5vz-python3.6-ephemeral_port_reserve-1.1.0

@FRidh
Copy link
Member

FRidh commented Jul 24, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

dotlambda
dotlambda requested changes Jul 24, 2018
View reviewed changes
pkgs/development/python-modules/ephemeral-port-reserve/default.nix
@@ -0,0 +1,16 @@
{ stdenv, buildPythonPackage, fetchPypi }:
buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is an application, not a library. In this case, it must use buildPythonApplication and be moved out of pythonPackages.
This file should be moved somewhere under pkgs/tools/networking.

pkgs/development/python-modules/ephemeral-port-reserve/default.nix
meta = with stdenv.lib; {
maintainers = with maintainers; [ jb55 ];
platforms = platforms.unix;
description = "Find an unused port, reliably";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homepage is missing

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python

Partial log (click to expand)

/nix/store/lwrc1yjzasmgh4k43s6pz49kbc099yl6-python-2.7.15

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.ephemeral_port_reserve, python3.pkgs.ephemeral_port_reserve

Partial log (click to expand)

reading manifest file 'ephemeral_port_reserve.egg-info/SOURCES.txt'
writing manifest file 'ephemeral_port_reserve.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/nmzhd15nk9y26d4kabwkqzrw0hl9bwcl-python2.7-ephemeral_port_reserve-1.1.0
/nix/store/fbljsw7iszmrvnvys7735frfrzv8x73z-python3.6-ephemeral_port_reserve-1.1.0

@jb55 jb55 closed this Jul 29, 2018
@dotlambda
Copy link
Member

@jb55 Why did you close?

@jb55
Copy link
Contributor Author

jb55 commented Jul 30, 2018

@dotlambda don't have time to fix this right now, trying to keep the noise down in the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jb55 @GrahamcOfBorg @ryantm @FRidh @dotlambda