Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amazon-ecr-credential-helper: init at 0.1.0 #44050

Merged
merged 1 commit into from Jul 25, 2018
Merged

amazon-ecr-credential-helper: init at 0.1.0 #44050

merged 1 commit into from Jul 25, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jul 24, 2018 •
edited

Motivation for this change

The Amazon ECR Docker Credential Helper is a credential helper for the Docker daemon that makes it easier to use Amazon Elastic Container Registry.

https://github.com/awslabs/amazon-ecr-credential-helper

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Jul 24, 2018
View reviewed changes
pkgs/tools/admin/amazon-ecr-credential-helper/default.nix Outdated

goPackagePath = "github.com/awslabs/amazon-ecr-credential-helper";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub instead of fetchurl because it relies on the hash of the contents of the repository instead of the hash of a tarball, and it would allow us to fix all GitHub src fetchers, if GitHub changes something about how it works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thank you for pointing that out! I was always thinking about the time it takes to fetch the src.

@ryantm
Copy link
Member

ryantm commented Jul 24, 2018

@GrahamcOfBorg build amazon-ecr-credential-helper

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yqgp6hmrj1zbd14vih7z8r5b6jxyqcfk-amazon-ecr-credential-helper-0.1.0-bin
shrinking /nix/store/yqgp6hmrj1zbd14vih7z8r5b6jxyqcfk-amazon-ecr-credential-helper-0.1.0-bin/bin/docker-credential-ecr-login
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yqgp6hmrj1zbd14vih7z8r5b6jxyqcfk-amazon-ecr-credential-helper-0.1.0-bin/bin
patching script interpreter paths in /nix/store/yqgp6hmrj1zbd14vih7z8r5b6jxyqcfk-amazon-ecr-credential-helper-0.1.0-bin
checking for references to /build in /nix/store/yqgp6hmrj1zbd14vih7z8r5b6jxyqcfk-amazon-ecr-credential-helper-0.1.0-bin...
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
/nix/store/yqgp6hmrj1zbd14vih7z8r5b6jxyqcfk-amazon-ecr-credential-helper-0.1.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8g8hwwbfs9m95qylc71grhcfl6lc0cbl-amazon-ecr-credential-helper-0.1.0-bin
shrinking /nix/store/8g8hwwbfs9m95qylc71grhcfl6lc0cbl-amazon-ecr-credential-helper-0.1.0-bin/bin/docker-credential-ecr-login
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8g8hwwbfs9m95qylc71grhcfl6lc0cbl-amazon-ecr-credential-helper-0.1.0-bin/bin
patching script interpreter paths in /nix/store/8g8hwwbfs9m95qylc71grhcfl6lc0cbl-amazon-ecr-credential-helper-0.1.0-bin
checking for references to /build in /nix/store/8g8hwwbfs9m95qylc71grhcfl6lc0cbl-amazon-ecr-credential-helper-0.1.0-bin...
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
/nix/store/8g8hwwbfs9m95qylc71grhcfl6lc0cbl-amazon-ecr-credential-helper-0.1.0-bin

@kalbasit
Copy link
Member Author

@ryantm PTAL

@ryantm
Copy link
Member

ryantm commented Jul 24, 2018

@GrahamcOfBorg build amazon-ecr-credential-helper

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/26jrp6z3aaj89zf817wdfr0k0fjlqrl8-amazon-ecr-credential-helper-0.1.0-bin
shrinking /nix/store/26jrp6z3aaj89zf817wdfr0k0fjlqrl8-amazon-ecr-credential-helper-0.1.0-bin/bin/docker-credential-ecr-login
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/26jrp6z3aaj89zf817wdfr0k0fjlqrl8-amazon-ecr-credential-helper-0.1.0-bin/bin
patching script interpreter paths in /nix/store/26jrp6z3aaj89zf817wdfr0k0fjlqrl8-amazon-ecr-credential-helper-0.1.0-bin
checking for references to /build in /nix/store/26jrp6z3aaj89zf817wdfr0k0fjlqrl8-amazon-ecr-credential-helper-0.1.0-bin...
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
/nix/store/26jrp6z3aaj89zf817wdfr0k0fjlqrl8-amazon-ecr-credential-helper-0.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin
shrinking /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin/bin/docker-credential-ecr-login
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin/bin
patching script interpreter paths in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin
checking for references to /build in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin...
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
/nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin

@ryantm
Copy link
Member

ryantm commented Jul 24, 2018

@GrahamcOfBorg eval
@GrahamcOfBorg build amazon-ecr-credential-helper

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

/nix/store/26jrp6z3aaj89zf817wdfr0k0fjlqrl8-amazon-ecr-credential-helper-0.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin
shrinking /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin/bin/docker-credential-ecr-login
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin/bin 
patching script interpreter paths in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin
checking for references to /tmp/nix-build-amazon-ecr-credential-helper-0.1.0.drv-0 in /nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin...
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
/nix/store/skmfyw2h8lldq0fa0ks5d3yjkfkgsbgm-amazon-ecr-credential-helper-0.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
find: '/nix/store/m1rj1c0wfh9nwn1sj29pp273373h82pz-amazon-ecr-credential-helper-0.1.0': No such file or directory
/nix/store/r71cri5z05svwdb34xigh6hpfv59axpp-amazon-ecr-credential-helper-0.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: amazon-ecr-credential-helper

Partial log (click to expand)

/nix/store/r71cri5z05svwdb34xigh6hpfv59axpp-amazon-ecr-credential-helper-0.1.0-bin

@ryantm ryantm merged commit fec22d4 into NixOS:master Jul 25, 2018
@kalbasit kalbasit deleted the add-aws-ecr-login branch July 25, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @ryantm @GrahamcOfBorg