Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-18.03: Update VLC to version 3.0.3 #43642

Merged
merged 2 commits into from Jul 19, 2018
Merged

release-18.03: Update VLC to version 3.0.3 #43642

merged 2 commits into from Jul 19, 2018

Conversation

stefano-m
Copy link
Contributor

Motivation for this change

Update VLC (and phonon-backend-vlc) to include fixes to security vulnerabilities.

See #43307

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

All executables run, with except of tribler that fails with 2 Python ImportErrors (sip and _tkinter), however, the same errors happen when running tribler from the stable channel.

Built packages:

  • vlc
  • vlc_npapi
  • libsForQt5.vlc
  • tribler
  • obs-studio
  • megaglest
  • libsForQt5.phonon-backend-vlc
  • cantata

@stefano-m
vlc: 2.2.8 -> 3.0.3
d96ade3 
Backported from master to solve a number of known security vulnerabilities.

Reference:
#43307
@stefano-m
phonon-backend-vlc: 0.9.0 -> 0.10.1
b0ea994 
Backported from master. Needed after vlc update
@FRidh FRidh added the 8.has: port to stable A PR already has a backport to the stable release. label Jul 17, 2018
@peterhoeg
Copy link
Member

Anyone running 18.03 who wants to try this out? I'm surprised that not more packages are being rebuilt than the ones listed.

@matthewbauer
Copy link
Member

matthewbauer commented Jul 18, 2018 •
edited

Works fine for me running:

nix run -f http://github.com/stefano-m/nixpkgs/archive/release-18.03.tar.gz vlc -c vlc

@stefano-m
Copy link
Contributor Author

Thanks all!

I was wondering whether it would make sense to add to the title of this PR that we are backporting to version 18.03?

@FRidh FRidh changed the title Update VLC to version 3.0.3 release-18.03: Update VLC to version 3.0.3 Jul 19, 2018
@andir
Copy link
Member

andir commented Jul 19, 2018

Works fine for me on 18.03 as well. I'll go ahead and merge it.

@andir andir merged commit 6dc8550 into NixOS:release-18.03 Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@stefano-m @peterhoeg @matthewbauer @andir @FRidh @GrahamcOfBorg @Janik-Haag