Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox: 5.2.12 -> 5.2.14 #43659

Merged
merged 1 commit into from Jul 17, 2018
Merged

virtualbox: 5.2.12 -> 5.2.14 #43659

merged 1 commit into from Jul 17, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 17, 2018

Motivation for this change

followup of #42934.

/cc @xeji

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ x Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: virtualbox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: virtualbox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: virtualbox

Partial log (click to expand)

kBuild: Compiling VBox-xpcom-components - /build/VirtualBox-5.2.14/src/libs/xpcom18a4/xpcom/components/xcDll.cpp
kBuild: Compiling VBox-xpcom-components - /build/VirtualBox-5.2.14/src/libs/xpcom18a4/xpcom/components/nsStaticComponentLoader.cpp
kBuild: Linking VBox-xpcom-components
kBuild: Compiling VBox-xpcom-threads - /build/VirtualBox-5.2.14/src/libs/xpcom18a4/xpcom/threads/plevent.c
kBuild: Compiling VBox-xpcom-threads - /build/VirtualBox-5.2.14/src/libs/xpcom18a4/xpcom/threads/nsAutoLock.cpp
kBuild: Compiling VBox-xpcom-threads - /build/VirtualBox-5.2.14/src/libs/xpcom18a4/xpcom/threads/nsEnvironment.cpp
kBuild: Compiling VBox-xpcom-threads - /build/VirtualBox-5.2.14/src/libs/xpcom18a4/xpcom/threads/nsEventQueue.cpp
kBuild: Compiling VBox-xpcom-threads - /build/VirtualBox-5.2.14/src/libs/xpcom18a4/xpcom/threads/nsEventQueueService.cpp
building of '/nix/store/2lqdbbdvrvr6kklzz592lkjv43d7zzlm-virtualbox-5.2.14.drv' timed out after 3600 seconds
error: build of '/nix/store/2lqdbbdvrvr6kklzz592lkjv43d7zzlm-virtualbox-5.2.14.drv' failed

@xeji
Copy link
Contributor

xeji commented Jul 17, 2018

@GrahamcOfBorg build linuxPackages.virtualboxGuestAdditions linuxPackages_latest.virtualboxGuestAdditions

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.virtualboxGuestAdditions, linuxPackages_latest.virtualboxGuestAdditions

Partial log (click to expand)

while evaluating the attribute 'linux_4_17' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:13763:3:
while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:13763:16:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.17.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:74:12:
while evaluating 'buildLinux' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:14061:16, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.17.nix�[0m:5:1:
while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:14061:23:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix�[0m:52:1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages.virtualboxGuestAdditions, linuxPackages_latest.virtualboxGuestAdditions

Partial log (click to expand)

Cannot nix-instantiate `linuxPackages.virtualboxGuestAdditions' because:
error: while evaluating the attribute 'buildCommand' of the derivation 'VirtualBox-GuestAdditions-5.2.14-4.14.56' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/pkgs/stdenv/generic/make-derivation.nix:175:11:
Architecture: aarch64-linux not supported for VirtualBox guest additions

Cannot nix-instantiate `linuxPackages_latest.virtualboxGuestAdditions' because:
error: while evaluating the attribute 'buildCommand' of the derivation 'VirtualBox-GuestAdditions-5.2.14-4.17.7' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/pkgs/stdenv/generic/make-derivation.nix:175:11:
Architecture: aarch64-linux not supported for VirtualBox guest additions

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: linuxPackages.virtualboxGuestAdditions, linuxPackages_latest.virtualboxGuestAdditions

Partial log (click to expand)

  CC      drivers/misc/echo/echo.mod.o
  CC      drivers/misc/eeprom/at24.mod.o
  CC      drivers/misc/eeprom/at25.mod.o
  CC      drivers/misc/eeprom/eeprom.mod.o
  CC      drivers/misc/eeprom/eeprom_93cx6.mod.o
  CC      drivers/misc/eeprom/eeprom_93xx46.mod.o
  CC      drivers/misc/eeprom/idt_89hpesx.mod.o
building of '/nix/store/p6xicgx9q04169c9nybykg8kzjgkhwj5-linux-4.17.7.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/hf4xcxsicyr1zpvyv8q9603ajww251ym-VirtualBox-GuestAdditions-5.2.14-4.17.7.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hf4xcxsicyr1zpvyv8q9603ajww251ym-VirtualBox-GuestAdditions-5.2.14-4.17.7.drv', '/nix/store/lwwb20y5ndbgdam9fxqpfxs5qy720h80-VirtualBox-GuestAdditions-5.2.14-4.14.56.drv' failed

@xeji
Copy link
Contributor

xeji commented Jul 17, 2018

ofborg timeouts are a pain (we need faster horses 😄 ), so I built these locally to check:

virtualbox
linuxPackages.virtualbox
linuxPackages.virtualboxGuestAdditions
linuxPackages_latest.virtualbox
linuxPackages_latest.virtualboxGuestAdditions

LGTM.

@xeji xeji merged commit 73c1d47 into NixOS:master Jul 17, 2018
xeji pushed a commit that referenced this pull request Jul 17, 2018
backport of #43659
closes #41360

(cherry picked from commit fa4c1ee)
@xeji
Copy link
Contributor

xeji commented Jul 17, 2018

backported to 18.03 in bbad2e5 because of #41360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants