Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scantailor-advanced: 1.0.15 -> 1.0.16 #43653

Merged
merged 1 commit into from Jul 18, 2018
Merged

scantailor-advanced: 1.0.15 -> 1.0.16 #43653

merged 1 commit into from Jul 18, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update and enable build for macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Jul 17, 2018
View reviewed changes
pkgs/applications/graphics/scantailor/advanced.nix
done
'';

desktopItem = makeDesktopItem {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it now includes this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does.

@xeji
Copy link
Contributor

xeji commented Jul 17, 2018

@GrahamcOfBorg build scantailor-advanced

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: scantailor-advanced

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1shi5dssprls2dymrnrwda0hx81r0ppx-scantailor-advanced-1.0.16
shrinking /nix/store/1shi5dssprls2dymrnrwda0hx81r0ppx-scantailor-advanced-1.0.16/bin/scantailor
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1shi5dssprls2dymrnrwda0hx81r0ppx-scantailor-advanced-1.0.16/bin
patching script interpreter paths in /nix/store/1shi5dssprls2dymrnrwda0hx81r0ppx-scantailor-advanced-1.0.16
checking for references to /build in /nix/store/1shi5dssprls2dymrnrwda0hx81r0ppx-scantailor-advanced-1.0.16...
postPatchMkspecs
postPatchMkspecs
/nix/store/1shi5dssprls2dymrnrwda0hx81r0ppx-scantailor-advanced-1.0.16

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: scantailor-advanced

Partial log (click to expand)

-- Installing: /nix/store/v2vqczmyv1s5v2x4zpaamxjd2scg9ly4-scantailor-advanced-1.0.16/share/applications/scantailor.desktop
-- Installing: /nix/store/v2vqczmyv1s5v2x4zpaamxjd2scg9ly4-scantailor-advanced-1.0.16/share/icons/hicolor/scalable/apps/ScanTailor.svg
-- Installing: /nix/store/v2vqczmyv1s5v2x4zpaamxjd2scg9ly4-scantailor-advanced-1.0.16/share/mime/packages/scantailor-project.xml
post-installation fixup
strip is /nix/store/8axizw5mf6dx7wip65nbkyrmlkhmjhc5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/v2vqczmyv1s5v2x4zpaamxjd2scg9ly4-scantailor-advanced-1.0.16/bin
patching script interpreter paths in /nix/store/v2vqczmyv1s5v2x4zpaamxjd2scg9ly4-scantailor-advanced-1.0.16
postPatchMkspecs
postPatchMkspecs
/nix/store/v2vqczmyv1s5v2x4zpaamxjd2scg9ly4-scantailor-advanced-1.0.16

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: scantailor-advanced

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yli319d9yzm461jrz0pyc05z88zn880g-scantailor-advanced-1.0.16
shrinking /nix/store/yli319d9yzm461jrz0pyc05z88zn880g-scantailor-advanced-1.0.16/bin/scantailor
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yli319d9yzm461jrz0pyc05z88zn880g-scantailor-advanced-1.0.16/bin
patching script interpreter paths in /nix/store/yli319d9yzm461jrz0pyc05z88zn880g-scantailor-advanced-1.0.16
checking for references to /build in /nix/store/yli319d9yzm461jrz0pyc05z88zn880g-scantailor-advanced-1.0.16...
postPatchMkspecs
postPatchMkspecs
/nix/store/yli319d9yzm461jrz0pyc05z88zn880g-scantailor-advanced-1.0.16

@xeji xeji merged commit e8e96e4 into NixOS:master Jul 18, 2018
@jfrankenau jfrankenau deleted the update-scantailor branch July 18, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jfrankenau @xeji @GrahamcOfBorg @FRidh