Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] home-assistant: mark as insecure #43660

Merged
merged 1 commit into from Jul 18, 2018
Merged

[18.03] home-assistant: mark as insecure #43660

merged 1 commit into from Jul 18, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jul 17, 2018 •
edited

Motivation for this change

The packaged version is susceptible to man-in-the-middle attacks.
See https://www.home-assistant.io/blog/2018/07/16/release-73-2/.
I also checked whether applying home-assistant/core@335c643 would work, but that patch doesn't apply cleanly.

The issue was fixed on master by 7682a1f.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @peterhoeg @FRidh

home-assistant: mark as insecure
a49962c 
The packaged version is susceptible to man-in-the-middle attacks.
See https://www.home-assistant.io/blog/2018/07/16/release-73-2/.
@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: home-assistant

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "homeassistant-0.65.5"
       ];
     }

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: home-assistant

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "homeassistant-0.65.5"
       ];
     }

@peterhoeg peterhoeg merged commit 2da449e into NixOS:release-18.03 Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @GrahamcOfBorg @matthewbauer @FRidh @peterhoeg