Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua5_3: 5.3.4 -> 5.3.5 #43643

Closed
wants to merge 1 commit into from
Closed

lua5_3: 5.3.4 -> 5.3.5 #43643

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 16, 2018

Minor bump.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 16, 2018

Haven't found the changelog yet, but presumably includes the fixes for 5.3.4 listed here: https://www.lua.org/bugs.html .

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lua5_3

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5
shrinking /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5/bin/luac
shrinking /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5/bin/lua
shrinking /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5/lib/liblua.so.5.3.5
gzipping man pages under /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5/share/man/
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5/lib  /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5/bin 
patching script interpreter paths in /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5
checking for references to /tmp/nix-build-lua-5.3.5.drv-0 in /nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5...
/nix/store/r2nn9sn4wirh5fry40l9gmcvfh99r5xr-lua-5.3.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lua5_3

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5
shrinking /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5/lib/liblua.so.5.3.5
shrinking /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5/bin/luac
shrinking /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5/bin/lua
gzipping man pages under /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5/share/man/
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5/lib  /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5/bin
patching script interpreter paths in /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5
checking for references to /build in /nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5...
/nix/store/x495ivrikhawyc93i3v0s19z5mjnxbgh-lua-5.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: lua5_3

Partial log (click to expand)

cd src && cp -d liblua.5.3.5.dylib /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5/lib
cd doc && cp -d lua.1 luac.1 /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5/share/man/man1
ln -s -f liblua.5.3.5.dylib /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5/lib/liblua.5.3.dylib
ln -s -f liblua.5.3.dylib /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5/lib/liblua.dylib
post-installation fixup
gzipping man pages under /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5/share/man/
strip is /nix/store/qvj6bdvy7vdaxi3my0nq8ghf14njh8wk-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5/lib  /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5/bin
patching script interpreter paths in /nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5
/nix/store/i1spdy2yvhz4vhn0xxi7k313h2ccjahc-lua-5.3.5

@dtzWill
Copy link
Member Author

dtzWill commented Jul 17, 2018

@GrahamcOfBorg build pkgsMusl.lua5_3 pkgsMusl.lua5_3_compat lua5_3_compat

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: lua5_3_compat

The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsMusl.lua5_3, pkgsMusl.lua5_3_compat

Partial log (click to expand)

cd src && cp -d liblua.5.3.5.dylib /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5/lib
cd doc && cp -d lua.1 luac.1 /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5/share/man/man1
ln -s -f liblua.5.3.5.dylib /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5/lib/liblua.5.3.dylib
ln -s -f liblua.5.3.dylib /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5/lib/liblua.dylib
post-installation fixup
gzipping man pages under /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5/share/man/
strip is /nix/store/qvj6bdvy7vdaxi3my0nq8ghf14njh8wk-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5/lib  /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5/bin
patching script interpreter paths in /nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5
/nix/store/wpnygdav3grpfk5jx1lbh48bd4ingkcc-lua-5.3.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pkgsMusl.lua5_3, pkgsMusl.lua5_3_compat, lua5_3_compat

Partial log (click to expand)

strip is /nix/store/9xzscgjlx45myl7dc47239wg0y98kc6d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dy2jf1rnpl1li4apk43ak4fynh876cfq-lua-5.3.5/lib  /nix/store/dy2jf1rnpl1li4apk43ak4fynh876cfq-lua-5.3.5/bin
patching script interpreter paths in /nix/store/169yqdb28k8ssj6xpp8shziys3bm7v7w-lua-5.3.5
patching script interpreter paths in /nix/store/dy2jf1rnpl1li4apk43ak4fynh876cfq-lua-5.3.5
checking for references to /build in /nix/store/169yqdb28k8ssj6xpp8shziys3bm7v7w-lua-5.3.5...
checking for references to /build in /nix/store/dy2jf1rnpl1li4apk43ak4fynh876cfq-lua-5.3.5...
waiting for the big garbage collector lock...
/nix/store/dy2jf1rnpl1li4apk43ak4fynh876cfq-lua-5.3.5
/nix/store/169yqdb28k8ssj6xpp8shziys3bm7v7w-lua-5.3.5
/nix/store/k3yxjpp7vv8nq0mjlpygnjmj0lfhrpq6-lua-5.3.5

@phi-gamma
Copy link
Contributor

See also: #43141

@dtzWill
Copy link
Member Author

dtzWill commented Jul 17, 2018

Whoops, closing in favor of that PR (#43141). Thanks!

@dtzWill dtzWill closed this Jul 17, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Merge failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @phi-gamma