Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksonnet: init at 0.11.0 #43644

Merged
merged 1 commit into from Jul 17, 2018
Merged

ksonnet: init at 0.11.0 #43644

merged 1 commit into from Jul 17, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 16, 2018

Motivation for this change

This adds ksonnet like #42596, addressing the changes suggested there.

/cc @nlewo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ksonnet

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/281is3gff2z7vrn09wsn90zhsji725mm-ksonnet-0.11.0-bin
shrinking /nix/store/281is3gff2z7vrn09wsn90zhsji725mm-ksonnet-0.11.0-bin/bin/ks
shrinking /nix/store/281is3gff2z7vrn09wsn90zhsji725mm-ksonnet-0.11.0-bin/bin/generate
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/281is3gff2z7vrn09wsn90zhsji725mm-ksonnet-0.11.0-bin/bin
patching script interpreter paths in /nix/store/281is3gff2z7vrn09wsn90zhsji725mm-ksonnet-0.11.0-bin
checking for references to /build in /nix/store/281is3gff2z7vrn09wsn90zhsji725mm-ksonnet-0.11.0-bin...
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ksonnet

Partial log (click to expand)

find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
find: '/nix/store/5d8lix09in579djy8f4h3djigizilrnp-ksonnet-0.11.0': No such file or directory
/nix/store/zjnbr1xa698kgpr61li5s26mb0w424w1-ksonnet-0.11.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ksonnet

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fy0kir0ypzrqc7v1c6fiapyl61i2w73h-ksonnet-0.11.0-bin
shrinking /nix/store/fy0kir0ypzrqc7v1c6fiapyl61i2w73h-ksonnet-0.11.0-bin/bin/generate
shrinking /nix/store/fy0kir0ypzrqc7v1c6fiapyl61i2w73h-ksonnet-0.11.0-bin/bin/ks
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fy0kir0ypzrqc7v1c6fiapyl61i2w73h-ksonnet-0.11.0-bin/bin
patching script interpreter paths in /nix/store/fy0kir0ypzrqc7v1c6fiapyl61i2w73h-ksonnet-0.11.0-bin
checking for references to /build in /nix/store/fy0kir0ypzrqc7v1c6fiapyl61i2w73h-ksonnet-0.11.0-bin...
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
/nix/store/fy0kir0ypzrqc7v1c6fiapyl61i2w73h-ksonnet-0.11.0-bin

@nlewo nlewo mentioned this pull request Jul 17, 2018
Closed
9 tasks
nlewo
nlewo requested changes Jul 17, 2018
View reviewed changes
pkgs/applications/networking/cluster/ksonnet/default.nix Outdated
@@ -0,0 +1,25 @@
{ lib, buildGoPackage, fetchFromGitHub, ... }:

let version = "0.11.0"; in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is then useless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, stripped that one :-)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ksonnet

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cvbxh8d4fmdx2nmsz4h0fjf388fgdrzs-ksonnet-0.11.0-bin
shrinking /nix/store/cvbxh8d4fmdx2nmsz4h0fjf388fgdrzs-ksonnet-0.11.0-bin/bin/generate
shrinking /nix/store/cvbxh8d4fmdx2nmsz4h0fjf388fgdrzs-ksonnet-0.11.0-bin/bin/ks
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cvbxh8d4fmdx2nmsz4h0fjf388fgdrzs-ksonnet-0.11.0-bin/bin
patching script interpreter paths in /nix/store/cvbxh8d4fmdx2nmsz4h0fjf388fgdrzs-ksonnet-0.11.0-bin
checking for references to /build in /nix/store/cvbxh8d4fmdx2nmsz4h0fjf388fgdrzs-ksonnet-0.11.0-bin...
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
/nix/store/cvbxh8d4fmdx2nmsz4h0fjf388fgdrzs-ksonnet-0.11.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ksonnet

Partial log (click to expand)

find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
find: '/nix/store/mjqy8wrrzs0blxd47c98sm31inyflxd7-ksonnet-0.11.0': No such file or directory
/nix/store/6hzavb1f9kgpnwxjxs8jsbh0ab9ncpjl-ksonnet-0.11.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ksonnet

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j71gyc58hvfbid3r1pn25w9bpdlsivbg-ksonnet-0.11.0-bin
shrinking /nix/store/j71gyc58hvfbid3r1pn25w9bpdlsivbg-ksonnet-0.11.0-bin/bin/ks
shrinking /nix/store/j71gyc58hvfbid3r1pn25w9bpdlsivbg-ksonnet-0.11.0-bin/bin/generate
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j71gyc58hvfbid3r1pn25w9bpdlsivbg-ksonnet-0.11.0-bin/bin 
patching script interpreter paths in /nix/store/j71gyc58hvfbid3r1pn25w9bpdlsivbg-ksonnet-0.11.0-bin
checking for references to /tmp/nix-build-ksonnet-0.11.0.drv-0 in /nix/store/j71gyc58hvfbid3r1pn25w9bpdlsivbg-ksonnet-0.11.0-bin...
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
/nix/store/j71gyc58hvfbid3r1pn25w9bpdlsivbg-ksonnet-0.11.0-bin

@nlewo
Copy link
Member

nlewo commented Jul 17, 2018

Thx!

@nlewo nlewo merged commit a7d17e2 into NixOS:master Jul 17, 2018
@flokli flokli mentioned this pull request Jun 23, 2019
Merged
10 tasks
@flokli flokli deleted the ksonnet branch June 23, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @nlewo