Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glava: adjust syntax in patchelf command #43645

Merged
merged 1 commit into from Jul 17, 2018
Merged

glava: adjust syntax in patchelf command #43645

merged 1 commit into from Jul 17, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 16, 2018

Motivation for this change

Properly adds missing libs (once again?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Sorry, my fault! I didn't realize patchelf wouldn't accept the argument in the first position, which is pretty much expected from CLIs.. I just found out that NixOS/patchelf#123 fixes that, but apparently that isn't used in nixpkgs yet.

@infinisil infinisil merged commit 76e4208 into NixOS:master Jul 17, 2018
@eadwu eadwu deleted the glava/fix-patchelf-syntax branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @infinisil @GrahamcOfBorg