Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: drop 5.6 and 7.0 #44197

Merged
merged 1 commit into from Aug 1, 2018
Merged

php: drop 5.6 and 7.0 #44197

merged 1 commit into from Aug 1, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 29, 2018 •
edited

Motivation for this change

Both 5.6 and 7.0 is currently on life support, as in only recieving
security related patches.

This will only continue until:

  • 2018-12-31 for PHP 5.6
  • 2018-12-01 for PHP 7.0

Both these dates are in the middle of the 18.09 lifecycle. So it would
be nice to not have them in the 18.09 stable release. Dropping them
now would also result in less maintanance in updating them.

The death dates can be seen on both these links:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @grahamc

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/3j7cdkznyf3rykb16pfm7i0ncaklqy46-php-7.2.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php

Partial log (click to expand)

these paths will be fetched (20.71 MiB download, 95.67 MiB unpacked):
  /nix/store/f23wxivkkcm9rxr6rik47w5mlgdac2lv-php-7.2.7
  /nix/store/gldafhy3amkqzlrjj23aqizkihkax8ai-systemd-238-lib
  /nix/store/rm0cnbmn5wg6wl7k467x6z42ddp5zpk9-libgcrypt-1.8.3
  /nix/store/v90zp63c5gv2qrxsqaq5nja51zxqsl59-postgresql-9.6.9-lib
copying path '/nix/store/v90zp63c5gv2qrxsqaq5nja51zxqsl59-postgresql-9.6.9-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/rm0cnbmn5wg6wl7k467x6z42ddp5zpk9-libgcrypt-1.8.3' from 'https://cache.nixos.org'...
copying path '/nix/store/gldafhy3amkqzlrjj23aqizkihkax8ai-systemd-238-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/f23wxivkkcm9rxr6rik47w5mlgdac2lv-php-7.2.7' from 'https://cache.nixos.org'...
/nix/store/f23wxivkkcm9rxr6rik47w5mlgdac2lv-php-7.2.7

@infinisil infinisil added this to the 18.09 milestone Jul 29, 2018
@etu
php: drop 5.6 and 7.0
7e6b76f 
Both 5.6 and 7.0 is currently on life support, as in only recieving
security related patches.

This will only continue until:
 - 2018-12-31 for PHP 5.6
 - 2018-12-01 for PHP 7.0

Both these dates are in the middle of the 18.09 lifecycle. So it would
be nice to not have them in the 18.09 stable release. Dropping them
now would also result in less maintanance in updating them.

The death dates can be seen on both these links:
 - https://secure.php.net/supported-versions.php
 - https://en.wikipedia.org/wiki/PHP#Release_history
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/4q8pdab4ldzhpyxi3cskcn379a0w5dnh-php-7.2.8/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/4q8pdab4ldzhpyxi3cskcn379a0w5dnh-php-7.2.8/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/4q8pdab4ldzhpyxi3cskcn379a0w5dnh-php-7.2.8/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/4q8pdab4ldzhpyxi3cskcn379a0w5dnh-php-7.2.8...
moving /nix/store/4q8pdab4ldzhpyxi3cskcn379a0w5dnh-php-7.2.8/sbin/* to /nix/store/4q8pdab4ldzhpyxi3cskcn379a0w5dnh-php-7.2.8/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/a902jv3gqnhz3qa88kc3q50q5v7zjdjh-php-7.2.8-dev
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/a902jv3gqnhz3qa88kc3q50q5v7zjdjh-php-7.2.8-dev
checking for references to /build in /nix/store/a902jv3gqnhz3qa88kc3q50q5v7zjdjh-php-7.2.8-dev...
/nix/store/4q8pdab4ldzhpyxi3cskcn379a0w5dnh-php-7.2.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/jibjzn2kl4vl1sm230rwcb0zsndxmqyc-php-7.2.8/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
/nix/store/jibjzn2kl4vl1sm230rwcb0zsndxmqyc-php-7.2.8/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
/nix/store/jibjzn2kl4vl1sm230rwcb0zsndxmqyc-php-7.2.8/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/jibjzn2kl4vl1sm230rwcb0zsndxmqyc-php-7.2.8...
moving /nix/store/jibjzn2kl4vl1sm230rwcb0zsndxmqyc-php-7.2.8/sbin/* to /nix/store/jibjzn2kl4vl1sm230rwcb0zsndxmqyc-php-7.2.8/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/gz42m345a55lgwljpanllwdsir1j78km-php-7.2.8-dev
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gz42m345a55lgwljpanllwdsir1j78km-php-7.2.8-dev
checking for references to /build in /nix/store/gz42m345a55lgwljpanllwdsir1j78km-php-7.2.8-dev...
/nix/store/jibjzn2kl4vl1sm230rwcb0zsndxmqyc-php-7.2.8

@Mic92 Mic92 merged commit 3ea0322 into NixOS:master Aug 1, 2018
@etu etu deleted the php-kill-56-and-70 branch August 1, 2018 12:04
@xeji xeji mentioned this pull request Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @GrahamcOfBorg @Mic92 @infinisil