rr: enable on 32bit x86 #44229
rr: enable on 32bit x86 #44229
Conversation
Lack of 32bit support led to the creation of an overlay to add it back again, but since it at least builds and seems to work don't see why we'd disallow it here :).
| @@ -51,6 +51,6 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| license = "custom"; | |||
| maintainers = with stdenv.lib.maintainers; [ pierron thoughtpolice ]; | |||
| platforms = ["x86_64-linux"]; | |||
| platforms = stdenv.lib.platforms.x86; | |||
There was a problem hiding this comment.
Are you sure that it actually works? Upstream seems not to build for 32bit: https://github.com/mozilla/rr/releases
There was a problem hiding this comment.
For one release they said:
No 32-bit release packages included because my 32-bit VM broke. Let's see if anyone complains.
so it could still work.
There was a problem hiding this comment.
Hmm.
looks
hahaha: from the 5.1.0 release notes:
No 32-bit release packages included because my 32-bit VM broke. Let's see if anyone complains.
There was a problem hiding this comment.
And just tried it with a 32bit xterm + bash and ... seems to work? Not obviously broken anyway :D.
There was a problem hiding this comment.
This will probably bit-rot over time, but then hopefully nobody will care about 32-bit.
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: rr Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: rr Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: rr Partial log (click to expand)
|
Lack of 32bit support led to the creation
of an overlay to add it back again,
but since it at least builds and seems to work
don't see why we'd disallow it here :).
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)