Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: Add config flag for tidy #44194

Merged
merged 1 commit into from Jul 29, 2018
Merged

php: Add config flag for tidy #44194

merged 1 commit into from Jul 29, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 29, 2018

Motivation for this change

I think this was missed in ae9932e
refactoring since this flag was added to master while the refactoring
was being reviewed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @FRidh @elitak

@etu
php: Add config flag for tidy
ff1c76a 
I think this was missed in ae9932e
refactoring since this flag was added to master while the refactoring
was being reviewed.
@elitak
Copy link
Contributor

elitak commented Jul 29, 2018

Looks okay; thanks.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php

Partial log (click to expand)

these paths will be fetched (18.15 MiB download, 89.35 MiB unpacked):
  /nix/store/3j7cdkznyf3rykb16pfm7i0ncaklqy46-php-7.2.7
  /nix/store/l500578wpfcka1vsaqd18rv5gwmlscp8-postgresql-9.6.9-lib
  /nix/store/ljs86xdssnqnqvpa6xnyhvkzfv6w4prg-libsodium-1.0.16
  /nix/store/x2xgzcz9jmiv102zj847xshqzxcly1qh-libossp-uuid-1.6.2
copying path '/nix/store/ljs86xdssnqnqvpa6xnyhvkzfv6w4prg-libsodium-1.0.16' from 'https://cache.nixos.org'...
copying path '/nix/store/x2xgzcz9jmiv102zj847xshqzxcly1qh-libossp-uuid-1.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/l500578wpfcka1vsaqd18rv5gwmlscp8-postgresql-9.6.9-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/3j7cdkznyf3rykb16pfm7i0ncaklqy46-php-7.2.7' from 'https://cache.nixos.org'...
/nix/store/3j7cdkznyf3rykb16pfm7i0ncaklqy46-php-7.2.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php

Partial log (click to expand)

copying path '/nix/store/zzjs2lkxdbw8v4h308b2n3s1pwg1kx8h-libpng-apng-1.6.34' from 'https://cache.nixos.org'...
copying path '/nix/store/7mcjabzimz7j6acrml3zbx9d63dvl13q-libssh2-1.8.0' from 'https://cache.nixos.org'...
copying path '/nix/store/8bybxk2f8xvvibn7aags8ypzi64v3y7g-freetype-2.9' from 'https://cache.nixos.org'...
copying path '/nix/store/4lb485igmqnj8kn9ai75rz9nrfa2acqi-curl-7.61.0' from 'https://cache.nixos.org'...
copying path '/nix/store/q0pfi80ji6pdccihqiy1ig18m2hzww7r-libxml2-2.9.8' from 'https://cache.nixos.org'...
copying path '/nix/store/vhg795ikyyplf97r6915awpflpchdf1y-linux-pam-1.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/v90zp63c5gv2qrxsqaq5nja51zxqsl59-postgresql-9.6.9-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/syqci9q5sba4ndayyfjc5jplds5in0cp-sqlite-3.24.0' from 'https://cache.nixos.org'...
copying path '/nix/store/f23wxivkkcm9rxr6rik47w5mlgdac2lv-php-7.2.7' from 'https://cache.nixos.org'...
/nix/store/f23wxivkkcm9rxr6rik47w5mlgdac2lv-php-7.2.7

@FRidh FRidh merged commit ab3eeb4 into NixOS:master Jul 29, 2018
@etu etu deleted the php-tidy branch July 29, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @elitak @GrahamcOfBorg @FRidh