Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter for SetPartApparent... #1884

Closed
wants to merge 2 commits into from

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jul 29, 2018

No description provided.

@@ -603,13 +603,14 @@ void Plugin::SetPartApparentDegreesOfFreedom(
// |Barycentric| centred on the given reference body.
auto const reference_body =
FindOrDie(celestials_, reference_body_index)->body();
auto const reference_rotation = PlanetariumRotation(*reference_body);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should use the existing PlanetariumRotation; the new overload should not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants