Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beegfs: 6.18 -> 7.0 #44210

Merged
merged 1 commit into from Jul 30, 2018
Merged

beegfs: 6.18 -> 7.0 #44210

merged 1 commit into from Jul 30, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Major version upgrade with new features:

  • Storage pools
  • Activity montoring and logging
Things done
  • Update beegfs package
  • Update kernel module package
  • Allow to disable helperd on the client (run client with GPL-only package).
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    nixos/tests/beegfs succeeds
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jul 30, 2018

local build of beegfs fails with

[----------] 1 test from NIC
[ RUN      ] NIC.nic
/build/v7-7.0-d7fc807f40aea0e88afd714cbecee7a0dbadabf7/common/tests/TestNIC.cpp:12: Failure
Value of: list.empty()
  Actual: true
Expected: false
[  FAILED  ] NIC.nic (4 ms)
[----------] 1 test from NIC (4 ms total)

[----------] 1 test from ListTk
[ RUN      ] ListTk.advance
[       OK ] ListTk.advance (0 ms)
[----------] 1 test from ListTk (0 ms total)

[----------] 2 tests from EntryIdTk
[ RUN      ] EntryIdTk.isValidHexToken
[       OK ] EntryIdTk.isValidHexToken (0 ms)
[ RUN      ] EntryIdTk.isValidEntryIdFormat
[       OK ] EntryIdTk.isValidEntryIdFormat (0 ms)
[----------] 2 tests from EntryIdTk (0 ms total)

[----------] 5 tests from TestBitStore
[ RUN      ] TestBitStore.calculateBitBlockCount
[       OK ] TestBitStore.calculateBitBlockCount (0 ms)
[ RUN      ] TestBitStore.setSizeAndReset
[       OK ] TestBitStore.setSizeAndReset (0 ms)
[ RUN      ] TestBitStore.getter
[       OK ] TestBitStore.getter (1 ms)
[ RUN      ] TestBitStore.setter
[       OK ] TestBitStore.setter (0 ms)
[ RUN      ] TestBitStore.serialization
[       OK ] TestBitStore.serialization (5 ms)
[----------] 5 tests from TestBitStore (6 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 12 test cases ran. (5012 ms total)
[  PASSED  ] 40 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] NIC.nic

 1 FAILED TEST
  YOU HAVE 12 DISABLED TESTS

builder for '/nix/store/4qcf3kqq64y5fiyl4xhxqbpqd81k76ws-beegfs-7.0.drv' failed with exit code 1
error: build of '/nix/store/4qcf3kqq64y5fiyl4xhxqbpqd81k76ws-beegfs-7.0.drv' failed

@markuskowa
Copy link
Member Author

This is weird.
I have built the package locally on two different machines (both running NixOS 18.03).
I can not reproduce this error (https://gist.github.com/markuskowa/60335f32a7bf077a108b8b7853f34402).

@xeji
Copy link
Contributor

xeji commented Jul 30, 2018

Thanks for checking. Since this is not a widely used package, let's merge for now and fix the error later in case other people report it 😃

@xeji xeji merged commit b59a13e into NixOS:master Jul 30, 2018
@markuskowa
Copy link
Member Author

Thanks! I'll keep an eye on that error.
I am using beegfs-6.18 on a live system right now. If there are any bugs in 7.0 I may discover them before release 18.09.

@markuskowa markuskowa deleted the beegfs-7 branch July 30, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @xeji @GrahamcOfBorg