Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restic fixes: pruning, process substitution #44203

Closed
wants to merge 3 commits into from
Closed

Restic fixes: pruning, process substitution #44203

wants to merge 3 commits into from

Conversation

jerith666
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

I think it would be nice to keep the options mostly in line with the borgbackup module. Have a look at it and see if you find some inspiration.

@jerith666
Copy link
Contributor Author

Okay, I took another stab at this, see af4bfd178e9.

Mic92
Mic92 requested changes Aug 6, 2018
View reviewed changes
nixos/modules/services/backup/restic.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/restic.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/restic.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/restic.nix Outdated Show resolved Hide resolved
@jerith666
restic: add dynamicFilesFrom
0a2c4f2
@jerith666
Merge remote-tracking branch 'channels/nixos-unstable'
00976b1 
Conflicts:
	nixos/modules/services/backup/restic.nix
          -- RuntimeDirectory and s3CredentialsFile on adjacent lines; keep both
@jerith666
Copy link
Contributor Author

jerith666 commented Aug 18, 2018 •
edited

0a2c4f2 uses RuntimeDirectory instead.

@angristan
Copy link
Member

Hello! I'm very interested in this. What is the state of this PR?

@jerith666
Copy link
Contributor Author

Sorry, I'd left a bunch of the discussion unresolved. I just re-read everything in light of the current tip of the restic-fixes branch (00976b1), and I think all the comments have been addressed.

Well, except "keep the options mostly in line with the borgbackup module". Perhaps I looked at that back when I was working on this, I just don't recall. :)

In any event, I've been running with these changes locally for a long time now, I haven't run into any issues with them.

@angristan
Copy link
Member

That's good to hear! I hope @Mic92 will be able to take another look at it sometime 🙂

@bbigras
Copy link
Contributor

bbigras commented Jan 30, 2020

Any progress on this? It would be nice to have it before the feature freeze.

Also, I head that pruning is expensive, so would it be a good idea to be able to set how often we want it to run?

@Mic92 Mic92 mentioned this pull request Jan 30, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/126

@Mic92 Mic92 closed this Mar 25, 2020
@Mic92
Copy link
Member

Mic92 commented Mar 25, 2020

superseeded by #78886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 requested changes

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jerith666 @dotlambda @angristan @bbigras @nixos-discourse @Mic92 @GrahamcOfBorg