jq: fix darwin build #44200

LnL7 · 2018-07-29T16:25:05Z

Motivation for this change

One of the tests failed on my builder but not locally because of some kind of timezone issue, hopefully this isn't also a problem on hydra.

/cc @Mic92

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

The tests depend on libjq which isn't installed in the correct location yet when the checkPhase runs.

dezgeg · 2018-07-29T16:26:57Z

pkgs/development/tools/jq/default.nix

@@ -9,7 +9,7 @@ stdenv.mkDerivation rec {
    sha256="0g29kyz4ykasdcrb0zmbrp2jqs9kv1wz9swx849i2d1ncknbzln4";
  };

-  outputs = [ "bin" "doc" "man" "dev" "lib" "out" ];
+  outputs = [ "out" "doc" "man" "dev" "lib" ];


I think:

outputs = [ "bin" "doc" "man" "dev" "out" ];

is more conventional. lib is quite rare.

I disagree out is the default output when unspecified, anything with multiple outputs should name the others accordingly. I don't want to look at the package definition to figure out what the default output is.

[ "bin" "lib" ] == [ "out" "lib" ] [ "lib" "bin" ] == [ "out" "bin" ]

Another reason not to do this.

$ nix-build -A jq /nix/store/sxp3lykdfknlxkkp7wr0g4jj2xh5cnlz-jq-1.5-bin $ ./result/bin/jq zsh: no such file or directory: ./result/bin/jq $ ls default.nix result-bin

Well that's just how all the other multiple-output packages currently work. In retrospect, it would have been good to be able to say e.g. outputs = [ "bin" "doc" "man" "dev" "lib" ]; i.e. no out anywhere, but this is how things are now.

Typically you don't need to know the name of the default output (except your nix-build example), because ${jq}/bin/jq and buildInputs = [ jq ]; both work.

No out anywhere: you typically need to pass some $PREFIX...

Please see https://nixos.org/nixpkgs/manual/#idm140737317822720, and 4.4.1 especially.

Yeah, I still disagree but there seems to be consensus so I'll drop this part.

GrahamcOfBorg · 2018-07-29T16:40:41Z

Success on aarch64-linux (full log)

Attempted: jq

Partial log (click to expand)

# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/build/jq-1.5'
make[2]: Leaving directory '/build/jq-1.5'
make[1]: Leaving directory '/build/jq-1.5'
/nix/store/lqj8gylg4sajwbxjkf0c6z243nxb8pyj-jq-1.5

GrahamcOfBorg · 2018-07-29T16:41:10Z

Success on x86_64-linux (full log)

Attempted: jq

Partial log (click to expand)

# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/build/jq-1.5'
make[2]: Leaving directory '/build/jq-1.5'
make[1]: Leaving directory '/build/jq-1.5'
/nix/store/wx62bn48vc9n65l7k6wcj5apmnyysjjy-jq-1.5

Profpatsch · 2018-07-30T14:12:07Z

pkgs/development/tools/jq/default.nix

@@ -9,7 +9,7 @@ stdenv.mkDerivation rec {
    sha256="0g29kyz4ykasdcrb0zmbrp2jqs9kv1wz9swx849i2d1ncknbzln4";
  };

-  outputs = [ "bin" "doc" "man" "dev" "lib" "out" ];
+  outputs = [ "out" "doc" "man" "dev" "lib" ];


Please see https://nixos.org/nixpkgs/manual/#idm140737317822720, and 4.4.1 especially.

Profpatsch · 2018-07-30T14:13:19Z

pkgs/development/tools/jq/default.nix

  doInstallCheck = true;
-  doCheck = true;


I’d rather enable these tests and disable them selectively on darwin.

I don't know what you mean by that, this doesn't disable any tests.

There is postInstallCheck.

I don't know what you mean by that, this doesn't disable any tests.

You quite obviously removed doCheck = true.

Why does it fail with doCheck (which runs make check), but succeed with installCheckTarget = "check" then?

All this does is run the tests after the libraries are installed installed to $lib instead of before, the tests failed because the libjq wasn't in the expected install location yet.

I wonder why it worked on linux then.

The way libraries are linked is a bit different on darwin, we link directly against libraries using their absolute path instead of using RPATH. I could have worked around it with DYLD_LIBRARY_PATH, but that's a bit harder and probably more brittle.

GrahamcOfBorg · 2018-07-30T14:18:47Z

Success on x86_64-darwin (full log)

Attempted: jq

Partial log (click to expand)

# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/private/tmp/nix-build-jq-1.5.drv-0/jq-1.5'
make[2]: Leaving directory '/private/tmp/nix-build-jq-1.5.drv-0/jq-1.5'
make[1]: Leaving directory '/private/tmp/nix-build-jq-1.5.drv-0/jq-1.5'
/nix/store/mh9f4wjwq9y6sdlxkqv8db367v1hvnfm-jq-1.5

GrahamcOfBorg · 2018-07-30T17:28:07Z

Success on x86_64-darwin (full log)

Attempted: jq

Partial log (click to expand)

# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/private/tmp/nix-build-jq-1.5.drv-0/jq-1.5'
make[2]: Leaving directory '/private/tmp/nix-build-jq-1.5.drv-0/jq-1.5'
make[1]: Leaving directory '/private/tmp/nix-build-jq-1.5.drv-0/jq-1.5'
/nix/store/6fcd8i8qkhn92bdjnjzmbs6knwry590z-jq-1.5-bin

GrahamcOfBorg · 2018-07-30T17:28:09Z

Success on x86_64-linux (full log)

Attempted: jq

Partial log (click to expand)

# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/build/jq-1.5'
make[2]: Leaving directory '/build/jq-1.5'
make[1]: Leaving directory '/build/jq-1.5'
/nix/store/sxp3lykdfknlxkkp7wr0g4jj2xh5cnlz-jq-1.5-bin

GrahamcOfBorg · 2018-07-30T17:28:31Z

Success on aarch64-linux (full log)

Attempted: jq

Partial log (click to expand)

# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[3]: Leaving directory '/build/jq-1.5'
make[2]: Leaving directory '/build/jq-1.5'
make[1]: Leaving directory '/build/jq-1.5'
/nix/store/z9w7l1zgsd2pijzpz9b7mkm8kps08dsx-jq-1.5-bin

jq: fix tests on darwin

a396905

The tests depend on libjq which isn't installed in the correct location yet when the checkPhase runs.

GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jul 29, 2018

dezgeg reviewed Jul 29, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jul 29, 2018

Mic92 mentioned this pull request Jul 30, 2018

jq fix darwin build #44228

Closed

Profpatsch requested changes Jul 30, 2018

View reviewed changes

LnL7 force-pushed the darwin-jq branch from 1553e3f to a396905 Compare July 30, 2018 17:11

Profpatsch approved these changes Jul 30, 2018

View reviewed changes

Profpatsch merged commit aeab0ec into NixOS:master Jul 30, 2018

LnL7 deleted the darwin-jq branch July 30, 2018 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jq: fix darwin build #44200

jq: fix darwin build #44200

LnL7 commented Jul 29, 2018

dezgeg Jul 29, 2018

LnL7 Jul 29, 2018

LnL7 Jul 29, 2018

dezgeg Jul 29, 2018

vcunat Jul 29, 2018

Profpatsch Jul 30, 2018

LnL7 Jul 30, 2018

GrahamcOfBorg commented Jul 29, 2018

GrahamcOfBorg commented Jul 29, 2018

Profpatsch Jul 30, 2018

Profpatsch Jul 30, 2018

LnL7 Jul 30, 2018

Mic92 Jul 30, 2018

Profpatsch Jul 30, 2018

LnL7 Jul 30, 2018

Profpatsch Jul 30, 2018

LnL7 Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

jq: fix darwin build #44200

jq: fix darwin build #44200

Conversation

LnL7 commented Jul 29, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Jul 29, 2018

GrahamcOfBorg commented Jul 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018