Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glpk: adopt error recovery patch #44201

Merged
merged 1 commit into from Jul 29, 2018
Merged

glpk: adopt error recovery patch #44201

merged 1 commit into from Jul 29, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Jul 29, 2018

Motivation for this change

This makes it possible to use "vanilla" glpk for sage and shouldn't affect anything else.

Unfortunately the github handle of the maintainer isn't listed in maintainer-list.nix and the maintainer hasn't been active in nixpkgs since 2010 anyways.

Details: https://trac.sagemath.org/ticket/20710#comment:18

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
glpk: adopt error recovery patch
bd2845b 
This makes it possible to use "vanilla" glpk for sage and shouldn't
affect anything else.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: glpk

Partial log (click to expand)

make[2]: Leaving directory '/build/glpk-4.65'
make[1]: Leaving directory '/build/glpk-4.65'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fclcqvbqjpqw0klw7mbpz6hymknv1lph-glpk-4.65
shrinking /nix/store/fclcqvbqjpqw0klw7mbpz6hymknv1lph-glpk-4.65/bin/glpsol
shrinking /nix/store/fclcqvbqjpqw0klw7mbpz6hymknv1lph-glpk-4.65/lib/libglpk.so.40.3.0
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fclcqvbqjpqw0klw7mbpz6hymknv1lph-glpk-4.65/lib  /nix/store/fclcqvbqjpqw0klw7mbpz6hymknv1lph-glpk-4.65/bin
patching script interpreter paths in /nix/store/fclcqvbqjpqw0klw7mbpz6hymknv1lph-glpk-4.65
checking for references to /build in /nix/store/fclcqvbqjpqw0klw7mbpz6hymknv1lph-glpk-4.65...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: glpk

Partial log (click to expand)

make[1]: Leaving directory '/build/glpk-4.65'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65
shrinking /nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65/bin/glpsol
shrinking /nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65/lib/libglpk.so.40.3.0
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65/lib  /nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65/bin
patching script interpreter paths in /nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65
checking for references to /build in /nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65...
/nix/store/8527p7ncaz6vf9h1i2vyia18292l29bz-glpk-4.65

@xeji xeji merged commit ae821e0 into NixOS:master Jul 29, 2018
@timokau timokau deleted the glpk-error-patch branch July 29, 2018 19:52
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: glpk

Partial log (click to expand)

these paths will be fetched (0.39 MiB download, 1.03 MiB unpacked):
  /nix/store/vr3srl9w4rycywjaiiaz94wxpschdfs8-glpk-4.65
copying path '/nix/store/vr3srl9w4rycywjaiiaz94wxpschdfs8-glpk-4.65' from 'https://cache.nixos.org'...
/nix/store/vr3srl9w4rycywjaiiaz94wxpschdfs8-glpk-4.65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @GrahamcOfBorg @xeji