Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

halide: init at 2018_02_15 #44207

Merged
merged 1 commit into from Aug 1, 2018
Merged

halide: init at 2018_02_15 #44207

merged 1 commit into from Aug 1, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Halide is a LLVM/C++ based language for image processing and computational photography.

Thanks to @ck3d for providing the derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build halide

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: halide

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: halide

Partial log (click to expand)

./CMakeFiles/CMakeOutput.log
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15
shrinking /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15/bin/HalideTraceViz
shrinking /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15/bin/HalideTraceDump
shrinking /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15/lib/libHalide.so
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15/lib  /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15/bin
patching script interpreter paths in /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15
checking for references to /build in /nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15...

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: halide

Partial log (click to expand)

[ 95%] Linking CXX static library ../../../lib/libhalide_blas.a
[ 95%] Built target halide_blas
Scanning dependencies of target test_halide_blas
[ 95%] Building CXX object apps/linear_algebra/tests/CMakeFiles/test_halide_blas.dir/test_halide_blas.cpp.o
[ 95%] Linking CXX executable ../../../bin/test_halide_blas
[ 95%] Built target test_halide_blas
Scanning dependencies of target eigen_benchmarks
[ 95%] Building CXX object apps/linear_algebra/benchmarks/CMakeFiles/eigen_benchmarks.dir/eigen_benchmarks.cpp.o
building of '/nix/store/cy20g7x8jfpx7ln5q4id9syy0wl9bx04-halide-2018.02.15.drv' timed out after 3600 seconds
error: build of '/nix/store/cy20g7x8jfpx7ln5q4id9syy0wl9bx04-halide-2018.02.15.drv' failed

@markuskowa
Copy link
Member Author

markuskowa commented Aug 1, 2018 •
edited

That's weird that build timed on x86_64. Build time on my local machine was 4:17 with 4 cores. Can you please retry the OfBorg build on x86_64-linux?

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

Fine, let's try again.
@GrahamcOfBorg build halide

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: halide

Partial log (click to expand)

/nix/store/vksf91j43jzdkmxb23gl0li9ww6jb4y5-halide-2018.02.15

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: halide

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: halide

Partial log (click to expand)

./CMakeFiles/CMakeOutput.log
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15
shrinking /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15/bin/HalideTraceDump
shrinking /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15/bin/HalideTraceViz
shrinking /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15/lib/libHalide.so
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15/lib  /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15/bin
patching script interpreter paths in /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15
checking for references to /build in /nix/store/29hbgskkmrgd4vnbj94xd6j2g7qr2r2z-halide-2018.02.15...

@markuskowa
Copy link
Member Author

Thanks! Looks like it worked now.

@xeji xeji merged commit 34f6b0c into NixOS:master Aug 1, 2018
@markuskowa markuskowa deleted the halide-pr branch August 7, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @xeji @GrahamcOfBorg