Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: Increase build timout to two days #44225

Merged
merged 1 commit into from Jul 30, 2018
Merged

chromium: Increase build timout to two days #44225

merged 1 commit into from Jul 30, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 30, 2018

Motivation for this change

We've had timeouts with the one day timeout, which still ends up being a complete waste of Hydra cycles. The amount of time spent is far from ideal, but I don't think we have the necessary builder feature granularity to increase the build speed reliably, so to work around that, here's a two day timeout instead.

The timeout: https://hydra.nixos.org/build/78455716
Earlier discussion: #39476

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jul 30, 2018

👍 we need faster horses eventually but in the meantime this doesn't hurt...

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: chromium

Partial log (click to expand)

[921/30499] ACTION //content/public/app:utility_manifest(//build/toolchain/linux:x64)
[922/30499] STAMP obj/content/public/app/utility_manifest.stamp
[923/30499] ACTION //content/public/app:renderer_manifest(//build/toolchain/linux:x64)
[924/30499] STAMP obj/content/public/app/renderer_manifest.stamp
[925/30499] STAMP obj/components/omnibox/browser/omnibox_vector_icons.stamp
[926/30499] STAMP obj/components/omnibox/common/common.stamp
[927/30499] CXX obj/courgette/courgette_lib/sssort.o
building of '/nix/store/rnv1nib759ladx1pi010b6na14mqhy60-chromium-68.0.3440.75.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/bchfdrz023lxkjgldcd6np7jx9kdrynv-chromium-68.0.3440.75.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bchfdrz023lxkjgldcd6np7jx9kdrynv-chromium-68.0.3440.75.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: chromium

Partial log (click to expand)

[3612/30224] CXX obj/skia/skia_core_and_effects/SkRasterPipelineBlitter.o
[3613/30224] CXX obj/skia/skia_core_and_effects/SkRecordOpts.o
[3614/30224] CXX obj/skia/skia_core_and_effects/SkRecordDraw.o
[3615/30224] CXX obj/skia/skia_core_and_effects/SkPictureData.o
[3616/30224] CXX obj/skia/skia_core_and_effects/SkBlurImageFilter.o
[3617/30224] CXX obj/skia/skia_core_and_effects/SkRecorder.o
ninja: build stopped: subcommand failed.
builder for '/nix/store/fln37ngxyy9pid5mn7jc0gmrd0p94dr5-chromium-68.0.3440.75.drv' failed with exit code 1
cannot build derivation '/nix/store/m0qp8rcxr09jvf7b9x49fy5gw9c6nf2c-chromium-68.0.3440.75.drv': 1 dependencies couldn't be built
error: build of '/nix/store/m0qp8rcxr09jvf7b9x49fy5gw9c6nf2c-chromium-68.0.3440.75.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: chromium

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@vcunat
Copy link
Member

vcunat commented Jul 30, 2018

ATM it was mainly about overloading the single horse. Eelco already did some step that should help it.

@vcunat vcunat self-assigned this Jul 30, 2018
vcunat
vcunat approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how this might hurt us, and it could help a lot.

vcunat added a commit that referenced this pull request Jul 30, 2018
@vcunat
Merge #44225: chromium: Increase build timout to two days
7a9835b 
(cherry picked from commit 437b604)
@vcunat vcunat merged commit 7679891 into NixOS:master Jul 30, 2018
vcunat added a commit that referenced this pull request Jul 30, 2018
@vcunat
Merge #44225: chromium: Increase build timout to two days
437b604
@vcunat vcunat added the 8.has: port to stable A PR already has a backport to the stable release. label Jul 30, 2018
@vcunat vcunat mentioned this pull request Aug 5, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @xeji @GrahamcOfBorg @vcunat