Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsemanage: fix bad meta.outputsToInstall (same as 57b9719e4cf601c617f02f59365e7218eefb9b0f) #44212

Closed
wants to merge 1 commit into from
Closed

libsemanage: fix bad meta.outputsToInstall (same as 57b9719e4cf601c617f02f59365e7218eefb9b0f) #44212

wants to merge 1 commit into from

Conversation

AmineChikhaoui
Copy link
Member

libsemanage: fix bad meta.outputsToInstall

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@AmineChikhaoui
same as 57b9719.
5659d69 
libsemanage: fix bad meta.outputsToInstall
AmineChikhaoui referenced this pull request Jul 29, 2018
@vcunat
checkpolicy: fix bad meta.outputsToInstall
57b9719 
This was silently blocking the channels.  Thanks amine* from IRC.
Maybe inheriting whole meta should be avoided and particular attributes
should be picked instead, as e.g. adding longDescription would have
unexpected consequences as well.
@vcunat
Copy link
Member

vcunat commented Jul 29, 2018

❤️

Did you use some specific test to find this?

@vcunat vcunat closed this in 78a988b Jul 29, 2018
@vcunat
Copy link
Member

vcunat commented Jul 29, 2018

Nitpick: I believe the second line of a commit message is best kept empty.

@AmineChikhaoui
Copy link
Member Author

@vcunat yeah same at what the mirror channel script does:

[amine@nixos:~/src/nixpkgs]$ curl -H 'Content-type: application/json' https://hydra.nixos.org/eval/1471317/store-paths | jq '.[]' -r > /tmp/store-paths

[amine@nixos:~/src/nixpkgs]$ /nix/store/lxjq3ca9ww5xbxi4p2rajimc0cam2ymy-nixos-channel-scripts/bin/generate-programs-index /tmp/cache.sqlite /tmp/programs.sqlite http://cache.nixos.org /tmp/store-paths .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmineChikhaoui @vcunat @GrahamcOfBorg