Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.cheroot: fix build #44216

Merged
merged 1 commit into from Jul 30, 2018
Merged

python3.pkgs.cheroot: fix build #44216

merged 1 commit into from Jul 30, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

python3.pkgs.backports_functools_lru_cache is null,
so we cannot require this for python3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

python3.pkgs.cheroot: fix build
4c66f11 
python3.pkgs.backports_functools_lru_cache is null,
so we cannot require this for python3
@dotlambda dotlambda requested a review from FRidh as a code owner July 30, 2018 05:08
@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.cheroot python3.pkgs.cheroot

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.cheroot, python3.pkgs.cheroot

Partial log (click to expand)

XFAIL cheroot/test/test_conn.py::test_Chunked_Encoding
  Server does not correctly read trailers/ending of the previous HTTP request, thus the second request fails as the server tries to parse b'Content-Type: application/json\r\n' as a Request-Line. This results in HTTP status code 400, instead of 413Ref: https://github.com/cherrypy/cheroot/issues/69
XFAIL cheroot/test/test_conn.py::test_598
  Sometimes this test fails due to low timeout. Ref: https://github.com/cherrypy/cherrypy/issues/598
SKIP [1] cheroot/test/test__compat.py:40: This code path only appears in Python 2 version.
SKIP [1] cheroot/test/test_server.py:102: Abstract sockets don't work currently
SKIP [1] cheroot/test/test_server.py:129: Test HTTP client is not able to work through UNIX socket currently
=============== 54 passed, 3 skipped, 2 xfailed in 40.52 seconds ===============
/nix/store/9lxnmghss2ni5x61h43rfv4fggilj86l-python2.7-cheroot-6.3.3
/nix/store/65yfq4363v295w1lf5xpmynar76i05xn-python3.6-cheroot-6.3.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.cheroot, python3.pkgs.cheroot

Partial log (click to expand)

XFAIL cheroot/test/test_conn.py::test_Chunked_Encoding
  Server does not correctly read trailers/ending of the previous HTTP request, thus the second request fails as the server tries to parse b'Content-Type: application/json\r\n' as a Request-Line. This results in HTTP status code 400, instead of 413Ref: https://github.com/cherrypy/cheroot/issues/69
XFAIL cheroot/test/test_conn.py::test_598
  Sometimes this test fails due to low timeout. Ref: https://github.com/cherrypy/cherrypy/issues/598
SKIP [1] cheroot/test/test__compat.py:40: This code path only appears in Python 2 version.
SKIP [1] cheroot/test/test_server.py:102: Abstract sockets don't work currently
SKIP [1] cheroot/test/test_server.py:129: Test HTTP client is not able to work through UNIX socket currently
=============== 54 passed, 3 skipped, 2 xfailed in 40.63 seconds ===============
/nix/store/lm1aygyg5yd23232cjkgpgp21rixjx4z-python2.7-cheroot-6.3.3
/nix/store/2rvlgm3ddf2dng25cdmb02k8flziwb3f-python3.6-cheroot-6.3.3

@dotlambda dotlambda merged commit 408bd2b into NixOS:master Jul 30, 2018
@dotlambda dotlambda deleted the fix-python3-cheroot branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @GrahamcOfBorg