Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dir.glob to list broken symlinks #6466

Merged

Conversation

straight-shoota
Copy link
Member

File.exists? is false for broken symlinks. But they should be included by glob. Any other glob implementation does this.

Fixes #6463

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 👍

@RX14 RX14 added this to the 0.26.0 milestone Aug 1, 2018
@RX14 RX14 merged commit 9cce189 into crystal-lang:master Aug 1, 2018
@straight-shoota straight-shoota deleted the jm/fix/dir-glob-symlink-entry branch August 1, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants