Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.{uunf,uucp,uuseg}: 10.0 -> 11.0.0 #44220

Merged
merged 4 commits into from Jul 31, 2018
Merged

ocamlPackages.{uunf,uucp,uuseg}: 10.0 -> 11.0.0 #44220

merged 4 commits into from Jul 31, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jul 30, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jul 30, 2018

@GrahamcOfBorg build stog jackline

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: stog, jackline

Partial log (click to expand)

moving /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0/doc to /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0
shrinking /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0/lib/ocaml/4.06.1/site-lib/tls/tls-lwt.cmxs
shrinking /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0/lib/ocaml/4.06.1/site-lib/tls/tls.cmxs
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0/lib
patching script interpreter paths in /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0
checking for references to /build in /nix/store/jl50ky8lq18ss5xv15y33h9mq8bhk6ig-ocaml4.06.1-tls-0.9.0...
cannot build derivation '/nix/store/4qz8cqr1pszj8bckgdmz2clgxxfwczk4-jackline-2017-12-24.drv': 2 dependencies couldn't be built
error: build of '/nix/store/07kcidr4jkzj5c30fnc38d4qhfajqvyb-stog-0.18.0.drv', '/nix/store/4qz8cqr1pszj8bckgdmz2clgxxfwczk4-jackline-2017-12-24.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: stog, jackline

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/xxfa0r4ahnxbbx0f5p3cb0fhlr666cl4-stog-0.18.0
/nix/store/34gyf8xdas7n09w7bmk8h9979nfa34db-jackline-2017-12-24

@Mic92
Copy link
Member

Mic92 commented Jul 30, 2018 •
edited

Can you restrict platforms so it will not build the package that is broken on aarch64?

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: stog, jackline

Partial log (click to expand)

  mk-stog mk-stog.byte mk-stog-ocaml-session \
  latex2stog latex2stog.byte \
  /nix/store/5ifj480lbl9ibq8pnjhf5i3xzp10fna6-stog-0.18.0/bin
make[1]: Leaving directory '/private/tmp/nix-build-stog-0.18.0.drv-0/source/src'
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5ifj480lbl9ibq8pnjhf5i3xzp10fna6-stog-0.18.0/lib  /nix/store/5ifj480lbl9ibq8pnjhf5i3xzp10fna6-stog-0.18.0/bin
patching script interpreter paths in /nix/store/5ifj480lbl9ibq8pnjhf5i3xzp10fna6-stog-0.18.0
/nix/store/5ifj480lbl9ibq8pnjhf5i3xzp10fna6-stog-0.18.0
/nix/store/nx3dkb200p3sgv6ib4mv13jac0kk9lgg-jackline-2017-12-24

@vbgl
Copy link
Contributor Author

vbgl commented Jul 31, 2018

Updated the meta.broken field of package uunf.

@Mic92 Mic92 merged commit 3183e9e into NixOS:master Jul 31, 2018
@vbgl vbgl deleted the ocaml-uunf-11.0.0 branch August 1, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Mic92 @GrahamcOfBorg