Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "progress-bar: re-draw last update if nothing new for 1sec." #2334

Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 6, 2018

Not ready for this yet, causes the prompt to disappear in nix repl
and more generally can overwrite non-progress-bar messages.

This reverts commit 44de71a.

Not ready for this yet, causes the prompt to disappear in nix repl
and more generally can overwrite non-progress-bar messages.

This reverts commit 44de71a.
@dtzWill
Copy link
Member Author

dtzWill commented Aug 6, 2018

See #2241 (comment) . Sorry about that.

@edolstra edolstra merged commit 103ad15 into NixOS:master Aug 6, 2018
@edolstra
Copy link
Member

edolstra commented Aug 6, 2018

Ah thanks, I ran into this yesterday (with the password prompt of an ssh:// store being overwritten by the progress bar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants