Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-language-server: 0.18.0 -> 0.19.0 #44567

Merged
merged 2 commits into from Aug 7, 2018
Merged

python-language-server: 0.18.0 -> 0.19.0 #44567

merged 2 commits into from Aug 7, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Aug 6, 2018 •
edited

Motivation for this change

Adding all of the extra dependencies isn't always desirable and
overriding a bunch of inputs is a bit cumbersome and brittle.

eg.

python-language-server.override { providers = ["rope"]; }

/cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
python-language-server: 0.18.0 -> 0.19.0
d12afcf
@LnL7
python-language-server: add providers option
5b2ff69 
Adding all of the extra dependencies isn't always desirable and
overriding a bunch of inputs is a bit cumbersome and brittle.

eg.

python-language-server.override { providers = ["rope"]; }
@LnL7 LnL7 requested a review from FRidh as a code owner August 6, 2018 19:14
@Mic92
Copy link
Member

Mic92 commented Aug 7, 2018

@GrahamcOfBorg build python-language-server

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python-language-server

Partial log (click to expand)

Cannot nix-instantiate `python-language-server' because:
error: attribute 'python-language-server' in selection path 'python-language-server' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: python-language-server

Partial log (click to expand)

Cannot nix-instantiate `python-language-server' because:
error: attribute 'python-language-server' in selection path 'python-language-server' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python-language-server

Partial log (click to expand)

Cannot nix-instantiate `python-language-server' because:
error: attribute 'python-language-server' in selection path 'python-language-server' not found

@Mic92 Mic92 merged commit 9d82512 into NixOS:master Aug 7, 2018
@LnL7 LnL7 deleted the python-language-server branch August 7, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @Mic92 @GrahamcOfBorg