Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.asana: 0.7.0 -> 0.7.1 #44561

Merged
merged 1 commit into from
Aug 6, 2018
Merged

pythonPackages.asana: 0.7.0 -> 0.7.1 #44561

merged 1 commit into from
Aug 6, 2018
+5 −6

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 6, 2018 •
edited
Loading

Motivation for this change

Also fixed the package build from
https://hydra.nixos.org/build/78900949.

requests_oauthlib seems to work fine at version 1.0 with asana, so
rather than creating our own override for asana it's fine to use 1.0
and patch setup.py.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ma27 Ma27 requested a review from FRidh as a code owner August 6, 2018 17:48
dotlambda
dotlambda reviewed Aug 6, 2018
View reviewed changes
pkgs/development/python-modules/asana/default.nix Outdated
};

checkInputs = [ pytest responses ];
propagatedBuildInputs = [ requests requests_oauthlib six ];

patchPhase = ''
postPatch = ''
echo > requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line still needed?

@dotlambda
Copy link
Member

dotlambda commented Aug 6, 2018 •
edited
Loading

What do you think of just applying Asana/python-asana@80919ea?
EDIT: Just saw this doesn't touch setup.py, so it won't work. However, we shouldn't be more strict than upstream, i.e. just use the version bounds from above commit.

@Ma27 Ma27 force-pushed the fix-python3-asana branch from 33d4ed7 to 825d435 Compare August 6, 2018 20:00
@Ma27
Copy link
Member Author

Ma27 commented Aug 6, 2018

@dotlambda isn't >=0.8.0<2.0 equal to my constraint (1.*) in case of requests_oauthlib?

@dotlambda
Copy link
Member

No, someone might actually want to use version 0.8.0.

@Ma27
python3Packages.asana: 0.7.0 -> 0.7.1

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44
Verified
Learn about vigilant mode
ca8e167 
Also fixed the package build from
https://hydra.nixos.org/build/78900949.

`requests_oauthlib` seems to work fine at version 1.0 with `asana`, so
rather than creating our own override for `asana` it's fine to use 1.0
and patch `setup.py`.
@Ma27 Ma27 force-pushed the fix-python3-asana branch from 825d435 to ca8e167 Compare August 6, 2018 20:16
@Ma27
Copy link
Member Author

Ma27 commented Aug 6, 2018

ack, fixed 👍

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.asana python3.pkgs.asana

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.asana, python3.pkgs.asana

Partial log (click to expand)

tests/test_client_tasks.py ...................                           [ 85%]
tests/test_client_teams.py .                                             [ 86%]
tests/test_client_users.py ....                                          [ 90%]
tests/test_client_webhooks.py ....                                       [ 94%]
tests/test_client_workspaces.py ...                                      [ 97%]
tests/test_errors.py ..                                                  [100%]

===================== 94 passed, 3 skipped in 0.99 seconds =====================
/nix/store/0zi0wkywmw4zffzf2x97hzj4ar378mi7-python2.7-asana-0.7.1
/nix/store/8vmvi3wnccladrhx3z0jynd3p0pjvn7f-python3.6-asana-0.7.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.asana, python3.pkgs.asana

Partial log (click to expand)

tests/test_client_tasks.py ...................                           [ 85%]
tests/test_client_teams.py .                                             [ 86%]
tests/test_client_users.py ....                                          [ 90%]
tests/test_client_webhooks.py ....                                       [ 94%]
tests/test_client_workspaces.py ...                                      [ 97%]
tests/test_errors.py ..                                                  [100%]

===================== 94 passed, 3 skipped in 5.10 seconds =====================
/nix/store/gbhnkq27hkvy7qv17wz3mf4msgwvnrjj-python2.7-asana-0.7.1
/nix/store/1ddyypp4fcqjpq10hwnzky0npkrv9bbz-python3.6-asana-0.7.1

@dotlambda dotlambda changed the title python3Packages.asana: 0.7.0 -> 0.7.1 pythonPackages.asana: 0.7.0 -> 0.7.1 Aug 6, 2018
@dotlambda dotlambda merged commit ea36b97 into NixOS:master Aug 6, 2018
@Ma27 Ma27 deleted the fix-python3-asana branch August 6, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @dotlambda @GrahamcOfBorg