Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.asgiref: 2.2.0 -> 2.3.2 #44563

Merged
merged 1 commit into from Aug 6, 2018
Merged

python3Packages.asgiref: 2.2.0 -> 2.3.2 #44563

merged 1 commit into from Aug 6, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 6, 2018 •
edited

Motivation for this change

2.3.2 supports async-timeout@3.x which fixes https://hydra.nixos.org/build/78889815.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner August 6, 2018 18:03
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.asgiref python3.pkgs.asgiref

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.asgiref

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.asgiref

Partial log (click to expand)

rootdir: /build/source, inifile: setup.cfg
plugins: asyncio-0.8.0
collected 12 items

tests/test_sync.py .........                                             [ 75%]
tests/test_testing.py .                                                  [ 83%]
tests/test_wsgi.py ..                                                    [100%]

========================== 12 passed in 5.27 seconds ===========================
/nix/store/5s49idifhy5cfmzqsfnbxky595305pla-python3.6-asgiref-2.3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.asgiref

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.asgiref

Partial log (click to expand)

rootdir: /build/source, inifile: setup.cfg
plugins: asyncio-0.8.0
collected 12 items

tests/test_sync.py .........                                             [ 75%]
tests/test_testing.py .                                                  [ 83%]
tests/test_wsgi.py ..                                                    [100%]

========================== 12 passed in 5.53 seconds ===========================
/nix/store/vfx1hmrszkp7sasi7rmkr2g6k59adaq6-python3.6-asgiref-2.3.2

@dotlambda dotlambda merged commit 3819c54 into NixOS:master Aug 6, 2018
@Ma27 Ma27 deleted the fix-python3-asgiref branch August 6, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @dotlambda @GrahamcOfBorg