magit-annex: provide external.git
#44552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the code to add the input from the `magit` expression to be reusable.
adisbladis
requested changes
Aug 7, 2018
| @@ -22,6 +22,10 @@ self: | |||
|
|
|||
| super = imported; | |||
|
|
|||
| addBuildDepends = pkg: xs: pkg.overrideAttrs (attrs: { | |||
There was a problem hiding this comment.
Why do we need this addBuildDepends abstraction instead of just chaining overrideAttrs?
There was a problem hiding this comment.
Well, personally, I feel like using named abstraction is a better alternative than coding by cut-and-paste---and there are four instances of that cut-and-paste in the file at present.
But if people don't think there's value, then, ehh, whatever.
|
IMHO named abstractions that save copy-paste are a good thing (just look at Haskell infra, for example), and `addBuildDepends` LGTM as such an abstraction, but I don't like the fact that `addBuildDepends` itself is duplicated between files. There's a bunch of other duplicated stuff there too.
If I were you I'd make a separate `lib.nix` or whatever with common subexpressions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code to add the input from the
magitexpression to be reusable.Motivation for this change
#44539 details how the
magit-annexpackage broke; this is the same breakage thatmagitexperienced---this refactors @ttuegel's solution for that package to be reusable, and adds a similar annotation tomagit-annex.Things done
Rebuilt
magitusing the refactored expression, which worked fine, and confirmed that themagit-annexexpression now installs.sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)