Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpich2: cleanup derivation, rename to mpich #44555

Merged
merged 2 commits into from Aug 6, 2018
Merged

mpich2: cleanup derivation, rename to mpich #44555

merged 2 commits into from Aug 6, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Some cleanup of the derivation (see below).
The official name of the package was changed from mpich2 to mpich in 2012 (https://www.mpich.org/about/overview/)

Things done
  • mpich2 -> mpich (added alias)
  • remove slurm dependency (not needed)
  • use most recent gfortran
  • turn enableParallelBulding on
  • ensure mpi[cc,cxx,fort] uses default compilers it was built with
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@markuskowa
mpich2: cleanup, rename to mpich
87925f0 
* mpich2 -> mpich
* remove slurm dependency
* use most recent gfortran
* turn enableParallelBulding on
* ensure mpi[cc,cxx,fort] uses default compilers it was built with
@markuskowa markuskowa changed the title mpich2: cleanupm derivation, rename to mpich mpich2: cleanup derivation, rename to mpich Aug 6, 2018
@joachifm
Copy link
Contributor

joachifm commented Aug 6, 2018

@GrahamcOfBorg build mpich

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: mpich

Partial log (click to expand)

make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/private/tmp/nix-build-mpich-3.2.1.drv-0/mpich-3.2.1/examples'
make[2]: Leaving directory '/private/tmp/nix-build-mpich-3.2.1.drv-0/mpich-3.2.1/examples'
make[1]: Leaving directory '/private/tmp/nix-build-mpich-3.2.1.drv-0/mpich-3.2.1'
post-installation fixup
fix rpath: /nix/store/sply1rh5zfmlb5k43jqdpxll8a63hday-mpich-3.2.1/bin/mpichversion
/nix/store/nqc6apq24v1qll6a69bj3yh1ipwz26zs-stdenv-darwin/setup: line 108: patchelf: command not found
builder for '/nix/store/mqjyxq2n21mdmbx5kf3j7yzwfm6s0dnp-mpich-3.2.1.drv' failed with exit code 127
error: build of '/nix/store/mqjyxq2n21mdmbx5kf3j7yzwfm6s0dnp-mpich-3.2.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mpich

Partial log (click to expand)

shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/hydra_pmi_proxy
shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/mpichversion
shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/mpiexec.hydra
shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/mpivars
gzipping man pages under /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/lib  /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin
patching script interpreter paths in /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1
checking for references to /build in /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1...
/nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpich

Partial log (click to expand)

shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/bin/hydra_persist
shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib/libmpicxx.so.12.1.1
shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib/libmpifort.so.12.1.1
shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib/libmpi.so.12.1.1
gzipping man pages under /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib  /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/bin
patching script interpreter paths in /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1
checking for references to /build in /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1...
/nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1

@markuskowa
Copy link
Member Author

markuskowa commented Aug 6, 2018 •
edited

I do not know how fix it on darwin, so I just remove it.
Note: I can not find any recent darwin builds on hydra. The last build I found failed on 17.09.

@xeji xeji merged commit 937e402 into NixOS:master Aug 6, 2018
@markuskowa markuskowa deleted the mpich-cleanup branch August 6, 2018 22:52
@markuskowa markuskowa mentioned this pull request Apr 4, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @joachifm @GrahamcOfBorg @xeji