Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-registry: Revert "[bot]: remove unreferenced code" #44546

Merged
merged 2 commits into from Aug 6, 2018
Merged

docker-registry: Revert "[bot]: remove unreferenced code" #44546

merged 2 commits into from Aug 6, 2018

Conversation

globin
Copy link
Member

@globin globin commented Aug 6, 2018

Motivation for this change

This code was referenced.

This reverts commit 87f5930.

cc @volth

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • N/A macOS
    • N/A other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • N/A Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • N/A Tested execution of all binary files (usually in ./result/bin/)
  • N/A Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg test docker-registry

@globin
Copy link
Member Author

globin commented Aug 6, 2018

@GrahamcOfBorg test docker-registry

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.docker-registry

Partial log (click to expand)

registry: running command: sync
registry: exit status 0
test script finished in 26.30s
cleaning up
killing client1 (pid 600)
killing client2 (pid 637)
killing registry (pid 619)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/n4jf8q465dc2w42f7v986qzgf5n9xkhb-vm-test-run-docker-registry

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.docker-registry

Partial log (click to expand)

client2: running command: sync
client2: exit status 0
test script finished in 238.06s
cleaning up
killing registry (pid 655)
killing client1 (pid 631)
killing client2 (pid 674)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/75y3x7skkjmrvbglghq3cpam2wv0n0qz-vm-test-run-docker-registry

@globin globin merged commit fcf067a into NixOS:master Aug 6, 2018
@globin globin deleted the docker-registry-fix branch August 6, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@globin @GrahamcOfBorg @pSub