Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services.plasma5: Make activationscript use absolute path to #44544

Merged
merged 1 commit into from Aug 7, 2018
Merged

services.plasma5: Make activationscript use absolute path to #44544

merged 1 commit into from Aug 7, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Aug 6, 2018 •
edited

kbuildsyscoca5

Motivation for this change

cc: @nand0p

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bkchr bkchr force-pushed the plasma_activation_script_use_absolute_path branch from f755475 to 60e1e81 Compare August 6, 2018 15:16
@infinisil
Copy link
Member

Backreference: #42910

@adisbladis
Copy link
Member

@GrahamcOfBorg test plasma5

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.plasma5

Partial log (click to expand)

building '/nix/store/ib52bc4n7r4xkpdc92m3r85fsqj0q7xa-xkb-validated.drv'...
building '/nix/store/n1vxqpn3rh80cvppj9id8zwlahp4vqvq-xscreensaver.pam.drv'...
cannot build derivation '/nix/store/fdj35z0pzb9q1g33dkmjygfn05qrc5qp-etc.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/ln1d7pwx59p3h7l2jwaavwygrn2qk5mg-nixos-system-machine-18.09.git.86fd9aa.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/85v1njp49hx8f9s169ink0fg3zl05r4r-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m0fqskhvl82xhl6r9c899ra5cg80b9v1-run-nixos-vm.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/vqqq70vyzzzp2h6cwzay5xcvc4v3a3av-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/aik6w7xp29sr2rc9nmkc08m8r6l106dy-nixos-test-driver-plasma5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/c2i0jpqg15imkqz7kd2kbvcgcj2avbvs-vm-test-run-plasma5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/c2i0jpqg15imkqz7kd2kbvcgcj2avbvs-vm-test-run-plasma5.drv' failed

@adisbladis adisbladis merged commit 8f36a31 into NixOS:master Aug 7, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.plasma5

Partial log (click to expand)

cannot build derivation '/nix/store/37sjk73dkj64y52rs5yv3jxwqrc6da6v-system-units.drv': 3 dependencies couldn't be built
Checking that all programs called by absolute paths in udev rules exist... OK
cannot build derivation '/nix/store/lshrzdjh6mr2dhyylhlf91cqqvmkr09p-etc.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/pfgar7xs2s8qy8wx1wyz396bx337saqb-nixos-system-machine-18.09.git.7d79b7d.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/38f54d77v4i9xdsxipv9i9fjym8vx6qb-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ky8djsnh115aykh4wza11917567ryk7l-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0x8vd2i884dia7jaa08ijwkg148jxzh5-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/klgpclyfaifcfab12bjd8si350jh8cfx-nixos-test-driver-plasma5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m750f9a6r08aj47912lb1xw25n07ss0a-vm-test-run-plasma5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/m750f9a6r08aj47912lb1xw25n07ss0a-vm-test-run-plasma5.drv' failed

jerith666 added a commit to jerith666/nixpkgs that referenced this pull request Aug 18, 2018
@jerith666
plasma5: improve kbuildsycoca activation script
93f96ad 
* silence normal output from the command

* avoid running it when the data it wants to update is encrypted

* specify explicit bash in kbuildsycoca5 su command

  when the activation script runs at boot time, the users' default
  shells (typically /run/current-system/sw/bin/bash) will not be
  available.  instead, specify an explicit store path for bash.

follow-on to NixOS#42910 and NixOS#44544
@jerith666 jerith666 mentioned this pull request Aug 18, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @infinisil @adisbladis @GrahamcOfBorg