Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: make a number of melpa packages work again #44543

Merged
merged 11 commits into from Aug 6, 2018
Merged

emacs: make a number of melpa packages work again #44543

merged 11 commits into from Aug 6, 2018

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Aug 6, 2018 •
edited

Motivation for this change

Fixes #44539

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Cc: @chaoflow @lovek323 @peti @the-kenny @jwiegley

peti
peti approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Any chance you could add a fix for #44539, too?

@peterhoeg
Copy link
Member Author

Sure

@peti peti merged commit 37adba4 into NixOS:master Aug 6, 2018
@peti
Copy link
Member

peti commented Aug 6, 2018

Thank you!

@peterhoeg peterhoeg deleted the u/emacs branch August 7, 2018 02:48
@peterhoeg peterhoeg restored the u/emacs branch August 7, 2018 03:00
@peterhoeg peterhoeg deleted the u/emacs branch August 7, 2018 03:26
@peterhoeg peterhoeg restored the u/emacs branch August 8, 2018 00:43
@oxij oxij mentioned this pull request Aug 13, 2018
Closed
@peterhoeg peterhoeg deleted the u/emacs branch October 8, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @peti @GrahamcOfBorg