Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.browser-cookie3: init at 0.6.4 #44562

Merged
merged 1 commit into from Aug 13, 2018
Merged

pythonPackages.browser-cookie3: init at 0.6.4 #44562

merged 1 commit into from Aug 13, 2018

Conversation

borisbabic
Copy link
Contributor

Motivation for this change

Add package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@borisbabic borisbabic requested a review from FRidh as a code owner August 6, 2018 17:49
@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.browser-cookie3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.browser-cookie3

Partial log (click to expand)

writing top-level names to browser_cookie3.egg-info/top_level.txt
reading manifest file 'browser_cookie3.egg-info/SOURCES.txt'
writing manifest file 'browser_cookie3.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/n29hkk4p242s23y9lssy3c3id03gqxjb-python3.6-browser-cookie3-0.6.4

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Judging from the GitHub repo, it seems like there are no tests. So please add

# No tests implemented
doCheck = false;

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python3.pkgs.browser-cookie3

Partial log (click to expand)

cannot build derivation '/nix/store/710vqvygw8six7aw8sbla2ap2c44mxbx-cairo-1.15.12.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/q6hp7sdpp2fikzmjl0h2rr3lqglzniir-absolute_gir_path.patch.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9yll33z86ap21msw6xa9b3fwnwzwvikl-python3.6-pycairo-1.16.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gxl5kw896mbsh4dydi1r2bkyv871g24i-gobject-introspection-1.56.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5qrjlzm53pc2s37j0q3vj0igbyxhcbib-python3.6-pygobject-3.26.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/7592hngwlj95qhyp0d4jpikqs5zijrsi-python3.6-dbus-python-1.2.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fj71hyp3ca1x4zj4p3kwzx80xzlf5vfp-python3.6-secretstorage-2.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6yjy3i6vx0ymqy3bfry541vgpqwf6pi9-python3.6-keyring-13.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c3lh3406j3wngv5iwpfysc1w2gndasxc-python3.6-browser-cookie3-0.6.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/c3lh3406j3wngv5iwpfysc1w2gndasxc-python3.6-browser-cookie3-0.6.4.drv' failed

@borisbabic
Copy link
Contributor Author

Yup, no tests 😅 I added that

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.browser-cookie3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.browser-cookie3

Partial log (click to expand)

Requirement already satisfied: pbkdf2 in /nix/store/l9dqi157528kgmjggwnagh0ma3dncwdv-python3.6-pbkdf2-1.3/lib/python3.6/site-packages (from browser-cookie3==0.6.4) (1.3)
Requirement already satisfied: entrypoints in /nix/store/vayz2a6rcj97hpw74vjac90f9nf96s5q-python3.6-entrypoints-0.2.3/lib/python3.6/site-packages (from keyring->browser-cookie3==0.6.4) (0.2.3)
Installing collected packages: browser-cookie3
Successfully installed browser-cookie3-0.6.4
/private/tmp/nix-build-python3.6-browser-cookie3-0.6.4.drv-0/browser-cookie3-0.6.4
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/if04msy0ncksgy05vj10873037z6m9qb-python3.6-browser-cookie3-0.6.4/lib
patching script interpreter paths in /nix/store/if04msy0ncksgy05vj10873037z6m9qb-python3.6-browser-cookie3-0.6.4
/nix/store/if04msy0ncksgy05vj10873037z6m9qb-python3.6-browser-cookie3-0.6.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.browser-cookie3

Partial log (click to expand)

Installing collected packages: browser-cookie3
Successfully installed browser-cookie3-0.6.4
/build/browser-cookie3-0.6.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/arjjswra7s0k92lfp1sb0dgayxz3m3yw-python3.6-browser-cookie3-0.6.4
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/arjjswra7s0k92lfp1sb0dgayxz3m3yw-python3.6-browser-cookie3-0.6.4/lib
patching script interpreter paths in /nix/store/arjjswra7s0k92lfp1sb0dgayxz3m3yw-python3.6-browser-cookie3-0.6.4
checking for references to /build in /nix/store/arjjswra7s0k92lfp1sb0dgayxz3m3yw-python3.6-browser-cookie3-0.6.4...
/nix/store/arjjswra7s0k92lfp1sb0dgayxz3m3yw-python3.6-browser-cookie3-0.6.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.browser-cookie3

Partial log (click to expand)

Installing collected packages: browser-cookie3
Successfully installed browser-cookie3-0.6.4
/build/browser-cookie3-0.6.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iidi9vwcpny5hvgsdf1765aclw9pii5k-python3.6-browser-cookie3-0.6.4
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iidi9vwcpny5hvgsdf1765aclw9pii5k-python3.6-browser-cookie3-0.6.4/lib
patching script interpreter paths in /nix/store/iidi9vwcpny5hvgsdf1765aclw9pii5k-python3.6-browser-cookie3-0.6.4
checking for references to /build in /nix/store/iidi9vwcpny5hvgsdf1765aclw9pii5k-python3.6-browser-cookie3-0.6.4...
/nix/store/iidi9vwcpny5hvgsdf1765aclw9pii5k-python3.6-browser-cookie3-0.6.4

@dotlambda dotlambda merged commit a5efa66 into NixOS:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@borisbabic @dotlambda @GrahamcOfBorg