Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrcpy: init at 1.2 #44101

Closed
wants to merge 2 commits into from
Closed

scrcpy: init at 1.2 #44101

wants to merge 2 commits into from

Conversation

DeltaEvo
Copy link
Member

@DeltaEvo DeltaEvo commented Jul 25, 2018 •
edited

Motivation for this change

Add scrcpy https://github.com/Genymobile/scrcpy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Jul 27, 2018

Did you investigate building the server from src? That would be preferable if possible.

@DeltaEvo
Copy link
Member Author

I tried quickly but I think I can build it by creating a subPackage and calling androidenv.buildGradleApp, but I don't know what license to choose then because androidenv.buildGradleApp make a package with an unfree license

Is there another way to do it ?
If not do I build it from source ?

@Mic92
Copy link
Member

Mic92 commented Jul 29, 2018

@GrahamcOfBorg build scrcpy

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: scrcpy

Partial log (click to expand)

Exception ignored in: <bound method Elf.__del__ of <mesonbuild.scripts.depfixer.Elf object at 0xffffbef30c50>>
Traceback (most recent call last):
  File "/nix/store/437d0y6wkkxyk43pr2zg9i6sml2rlxrj-meson-0.46.1/lib/python3.6/site-packages/mesonbuild/scripts/depfixer.py", line 132, in __del__
    if self.bf:
AttributeError: 'Elf' object has no attribute 'bf'
FAILED: meson-install
/nix/store/grlcs2s6hzmra5r6sdb2l612q3002ssn-python3-3.6.6/bin/python3.6m /nix/store/437d0y6wkkxyk43pr2zg9i6sml2rlxrj-meson-0.46.1/bin/meson --internal install /build/source/build/meson-private/install.dat
ninja: build stopped: subcommand failed.
builder for '/nix/store/f9i2mb96syln3hqx1ds2hncrypmzgrf6-scrcpy-1.2.drv' failed with exit code 1
error: build of '/nix/store/f9i2mb96syln3hqx1ds2hncrypmzgrf6-scrcpy-1.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: scrcpy

Partial log (click to expand)

Exception ignored in: <bound method Elf.__del__ of <mesonbuild.scripts.depfixer.Elf object at 0x7ffff7eb3c50>>
Traceback (most recent call last):
  File "/nix/store/cpawq57lnrifd8zgx5mllg3i8adsaypv-meson-0.46.1/lib/python3.6/site-packages/mesonbuild/scripts/depfixer.py", line 132, in __del__
    if self.bf:
AttributeError: 'Elf' object has no attribute 'bf'
FAILED: meson-install
/nix/store/8wfgl06xbcsxs6pmwr3n04kyhnvsh31d-python3-3.6.6/bin/python3.6m /nix/store/cpawq57lnrifd8zgx5mllg3i8adsaypv-meson-0.46.1/bin/meson --internal install /build/source/build/meson-private/install.dat
ninja: build stopped: subcommand failed.
builder for '/nix/store/gqhih94yvh4grsml985xyrz9wv485as8-scrcpy-1.2.drv' failed with exit code 1
error: build of '/nix/store/gqhih94yvh4grsml985xyrz9wv485as8-scrcpy-1.2.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jul 30, 2018

I get the same error when building the package.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: scrcpy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@ryantm ryantm self-requested a review July 30, 2018 15:51
ryantm
ryantm requested changes Jul 30, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it build.

@Mic92 Mic92 mentioned this pull request Jul 31, 2018
Merged
9 tasks
@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build scrcpy

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: scrcpy

Partial log (click to expand)

while evaluating anonymous function at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/pkgs/top-level/stage.nix:12:1, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/pkgs/top-level/default.nix:87:26:
while evaluating 'fix' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:19:9, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/pkgs/top-level/stage.nix:180:3:
while evaluating 'extends' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:19:20:
while evaluating 'extends' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:42:
while evaluating 'allPackages' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/pkgs/top-level/stage.nix:94:23, called from /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/lib/fixed-points.nix:44:67:
attribute 'scrcpy' at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/pkgs/top-level/all-packages.nix:8683:3 already defined at /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/pkgs/top-level/all-packages.nix:5027:3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: scrcpy

Partial log (click to expand)

while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/stage.nix:12:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/default.nix:87:26:
while evaluating 'fix' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:19:9, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/stage.nix:180:3:
while evaluating 'extends' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:19:20:
while evaluating 'extends' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:42:
while evaluating 'allPackages' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/stage.nix:94:23, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/fixed-points.nix:44:67:
attribute 'scrcpy' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:8683:3 already defined at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:5027:3

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: scrcpy

Partial log (click to expand)

while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/top-level/stage.nix:12:1, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/top-level/default.nix:87:26:
while evaluating 'fix' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:19:9, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/top-level/stage.nix:180:3:
while evaluating 'extends' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:19:20:
while evaluating 'extends' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:42:
while evaluating 'extends' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:24, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:42:
while evaluating 'allPackages' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/top-level/stage.nix:94:23, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/fixed-points.nix:44:67:
attribute 'scrcpy' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/top-level/all-packages.nix:8683:3 already defined at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/top-level/all-packages.nix:5027:3

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

closing in favor of #44249

@xeji xeji closed this Aug 1, 2018
@DeltaEvo DeltaEvo deleted the scrcpy branch August 1, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DeltaEvo @ryantm @Mic92 @GrahamcOfBorg @xeji