Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d7b657b81794
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a5f85ca69c74
Choose a head ref
  • 12 commits
  • 5 files changed
  • 2 contributors

Commits on Jul 23, 2018

  1. use internal str.sub! for date parsing (without frame info) 

    MRI has all of the date code in C and also avoids $~ and friends
... expected to noticeably improve Date.parse/_parse performance
    @kares
    kares committed Jul 23, 2018
    Copy the full SHA
    0e00652 View commit details

  2. review regexp match?-ing - MRI doesn't do dynamic dispatch 

    str.match? always does 'real' Regexp#match? no matter of patches
+ also do not use same (throw away) array for different things
    @kares
    kares committed Jul 23, 2018
    Copy the full SHA
    ddaad41 View commit details

  3. [refactor] use match? instead of =~ where possible

    @kares
    kares committed Jul 23, 2018
    Copy the full SHA
    3ff8998 View commit details

  4. [refactor] a few str.sub! left-overs in date/format.rb

    @kares
    kares committed Jul 23, 2018
    Copy the full SHA
    82f2c9e View commit details

Commits on Jul 24, 2018

  1. [refactor] avoid rest of =~ with a match private helper 

    ... now we can not blame $frame "globals" for being slow
    @kares
    kares committed Jul 24, 2018
    Copy the full SHA
    4f73f58 View commit details

  2. [refactor] move _parse_day internal to native 

    this seems to make a difference - indy doesn't get better ...
its ~ the same if the left-over .rb impl gets to use `subs()`
    @kares
    kares committed Jul 24, 2018
    Copy the full SHA
    259170e View commit details

Commits on Jul 25, 2018

  1. [refactor] move most Date._parse (delegates) into native 

    with indy on GraalVM we (almost) meet MRI 2.5 performance
... except `Date.parse('2018-07-17', false)` being 2x slower
    @kares
    kares committed Jul 25, 2018
    Copy the full SHA
    575584b View commit details

  2. do HAVE checks before various parses + cleanup Date _parse(s) 

    gets us close to MRI performance -> pretty much resolves GH-5255

... also added a b|B check (which MRI doesn;t have) for parse_bc
    @kares
    kares committed Jul 25, 2018
    Copy the full SHA
    ad19a12 View commit details

  3. [refactor] don't expose native _parse internals + move sla/dot

    @kares
    kares committed Jul 25, 2018
    Copy the full SHA
    5aaef90 View commit details

  4. move Date's parse_time to native - matched up with MRI 

    ... regexp was slightly different in JRuby's format.rb
    @kares
    kares committed Jul 25, 2018
    Copy the full SHA
    5d9d54c View commit details

  5. [perf] improve Date._parse for dates - don't do time parsing 

    3x speed improvement for raw dates `Date._parse('2000-01-01')`
    @kares
    kares committed Jul 25, 2018
    Copy the full SHA
    4109d58 View commit details

  6. Merge pull request #5259 from kares/date-speed 

    [refactor] improve Date parsing performance
    @kares
    kares authored Jul 25, 2018
    Copy the full SHA
    a5f85ca View commit details
Loading