gem-config: fix capybara-webkit on Darwin #44098
Conversation
GrahamcOfBorg
added
6.topic: darwin
| @@ -69,7 +69,8 @@ in | |||
| }; | |||
|
|
|||
| capybara-webkit = attrs: { | |||
| buildInputs = [ qt48 ]; | |||
| buildInputs = [ qt48 ] ++ stdenv.lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Cocoa ]; | |||
| NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.isDarwin "-I${libcxx}/include/c++/v1"; | |||
There was a problem hiding this comment.
Strange, libcxx is part of the darwin stdenv. I would expect it to work without this.
There was a problem hiding this comment.
Seems to be required in more places than just here:
https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=nix_cflags_compile+isdarwin+libcxx&type=
There was a problem hiding this comment.
For llvm it's expected since we want the version that matches the llvm version we're building, the others I don't understand.
There was a problem hiding this comment.
Maybe ruby's build system uses the c compiler to compile c++ so the libcxx flags are not added?
There was a problem hiding this comment.
In Python it might be a similar problem.
There was a problem hiding this comment.
# Gemfile
source "https://rubygems.org"
gem "capybara-webkit"
Then run bundle from the bundler package followed by bundix (also in nixpkgs).
There was a problem hiding this comment.
Did you manage to test this @LnL7 ?
There was a problem hiding this comment.
@alyssais I suppose you have tested this? Then I could merge it as well.
There was a problem hiding this comment.
Yep! Been using it successfully for weeks. Without this change it didn't work at all.
There was a problem hiding this comment.
Yeah sorry about the delay, I forgot about it because of a long qt build.
@Mic92 Good point about CC/CXX, it's probably a similar problem as we've seen with python.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)