Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.potr: 1.0.1 -> 1.0.2 #44096

Merged
merged 1 commit into from Jul 29, 2018
Merged

pythonPackages.potr: 1.0.1 -> 1.0.2 #44096

merged 1 commit into from Jul 29, 2018

Conversation

alyssais
Copy link
Member

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from FRidh as a code owner July 25, 2018 16:21
@FRidh
Copy link
Member

FRidh commented Jul 26, 2018

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

@alyssais
Copy link
Member Author

@FRidh thanks, I've updated the commit.

@FRidh
Copy link
Member

FRidh commented Jul 28, 2018

@GrahamcOfBorg build pythonPackages.potr python3Packages.potr

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.potr, python3Packages.potr

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_potr.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/j9kc16x72c8nhiky3iwzhbdwmv90xil0-python2.7-python-potr-1.0.2
/nix/store/iyhvk85455yf01ri7fzf3sqz998fbw8q-python3.6-python-potr-1.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.potr, python3Packages.potr

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_potr.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ghag3w5ych9qzh4awgp1jm1mbl9ngxdw-python2.7-python-potr-1.0.2
/nix/store/l9ladj78cm79aivhpxdib1brnv5cl0c1-python3.6-python-potr-1.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.potr, python3Packages.potr

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_potr.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/k77qlxrxxvm36r82pfix2v8ybrq7qfxs-python2.7-python-potr-1.0.2
/nix/store/dphfn8xx39crqnzk8invpvpzz3k73hkr-python3.6-python-potr-1.0.2

@xeji xeji merged commit 4e33431 into NixOS:master Jul 29, 2018
@alyssais alyssais deleted the potr branch August 13, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @FRidh @GrahamcOfBorg @xeji