Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Random#rand(Range(Float, Float)) to return Float #6445

Merged
merged 2 commits into from Jul 29, 2018
Merged

Fix Random#rand(Range(Float, Float)) to return Float #6445

merged 2 commits into from Jul 29, 2018

Conversation

straight-shoota
Copy link
Member

Fixes #6444

Sija
Sija reviewed Jul 25, 2018
View reviewed changes
src/random.cr
@@ -278,7 +278,7 @@ module Random
# ```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a doc update too (2 lines above).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

@RX14 RX14 added this to the Next milestone Jul 29, 2018
@RX14 RX14 merged commit bae4086 into crystal-lang:master Jul 29, 2018
@straight-shoota straight-shoota deleted the jm/fix/random-rand-float-range branch July 30, 2018 00:15
@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straight-shoota @Sija @RX14