Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python docs: improve override examples #44104

Merged
merged 3 commits into from Jul 26, 2018
Merged

Conversation

erikarvstedt
Copy link
Member

Please see the individual commit messages for explanations of all changes.

The `pythonPackages` definition is redundant
1. Use the same approach like in the overlay example:
   Override `python` instead of `pythonPackages` so that
   `python.pkgs` refers to the new package set like `pythonPackages`.

   This also fixes a bug in the original example where
   `pkgs.fetchgit` was not in scope.

   Add an extra example to illustrate how to override just a
   package set.

2. Fix mix-up between `super` and `self` in the explanation text.
   Also, simplify the explanation.
Use example package `zerobin` instead of `bepasty-server` which
is no longer part of python-packages.
This fixes the examples for current nixpkgs versions.
@erikarvstedt erikarvstedt changed the title Python docs python docs: improve override examples Jul 25, 2018
@FRidh
Copy link
Member

FRidh commented Jul 26, 2018

Thanks, this is much better.

@FRidh FRidh merged commit 443cbd7 into NixOS:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants