@GrahamcOfBorg eval

I think we should remove mkYarnPackage from nixpkgs as it's misleading maintainers that they can use it in nixpkgs. Because it does IFD it can't be used by hydra.

@zimbatm this is why I've set hydraPlatforms = []; to avoid hydra builds.

If the package is not built by hydra then how about maintaining the definition outside of nixpkgs? It's not yet popular but https://github.com/nix-community/nur might be a good solution for that.

That looses the convenience of nixpkgs such as nix-shell -p heroku, etc. It makes installing of heroku harder, so I'd like to understand the gain of splitting nix packages into another repo.

I understand that hydra not building is inconvenient already, but why make it even more so? :)

Why not use node2nix? It should just take adding heroku to the node-packages.json file & regenerating it.

Also it's important to remember that even if hydraPlatforms = [] a build is still attempted if another package depends on it.

Not sure who mentioned it to me (@zimbatm?) but it also doesn't work with node2nix.

yes I have a branch here: https://github.com/zimbatm/nixpkgs/tree/heroku-7.5.10

It fails with npm ERR! network request to http://www.example.com/@heroku-cli%2fcolor failed, reason: getaddrinfo ENOTFOUND www.example.com www.example.com:80 because I suspect it doesn't get placed in the right location. I suspect that npm2nix doesn't understand the @team/package format and places the package in the wrong location.

I would like to merge this as it works fine and brings heroku-cli back. We can always improve the implementation later.

Anyone against merging?

Correction: It doesn't work for me :-)

% nix-shell -p heroku                                                                                              :(
these derivations will be built:
  /nix/store/hxg3sh70n762s3jxvp2r2956dfhnxdn7-heroku-7.5.7-modules-7.5.7.drv
  /nix/store/vbmka5djxps0wb5mzkw3w63gs253rca5-heroku-7.5.7.drv
building '/nix/store/hxg3sh70n762s3jxvp2r2956dfhnxdn7-heroku-7.5.7-modules-7.5.7.drv'...
configuring
building
yarn config v1.9.4
success Set "yarn-offline-mirror" to "/nix/store/rvvzns36hs08bkhg2b46p67w2bzqdm4j-offline".
Done in 0.03s.
yarn install v1.9.4
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "EACCES: permission denied, unlink '/nix/store/rvvzns36hs08bkhg2b46p67w2bzqdm4j-offline/semver-5.5.0.tgz'".
info If you think this is a bug, please open a bug report with the information provided in "/build/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
builder for '/nix/store/hxg3sh70n762s3jxvp2r2956dfhnxdn7-heroku-7.5.7-modules-7.5.7.drv' failed with exit code 1
cannot build derivation '/nix/store/vbmka5djxps0wb5mzkw3w63gs253rca5-heroku-7.5.7.drv': 1 dependencies couldn't be built
error: build of '/nix/store/vbmka5djxps0wb5mzkw3w63gs253rca5-heroku-7.5.7.drv' failed

stumbled across this (I'm the maintainer of the Heroku CLI). I don't know much about nixos, but you guys might be able to do something like we do for our homebrew formula.

That tarball is all the node js files needed to run heroku. If you either put a node bin on the PATH or map the shebang to node >=8 like we do in the formula that would be much easier I think. No need to mess with yarn.

@jdxcode whlie we have you here. first thank you for the pointers how to package heroku-cli. Is there also the option to disable self-update?

yes with HEROKU_DISABLE_AUTOUPDATE=1

@jdxcode I've implemented your suggestion as an alternative to this PR here: #46804

Thank you!