pscircle: init at v1.0.0 #42870
Merged
pscircle: init at v1.0.0 #42870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg eval |
|
@GrahamcOfBorg eval |
ryantm
reviewed
Jul 3, 2018
| name = "pscircle-${version}"; | ||
| version = "1.0.0"; | ||
|
|
||
| src = fetchGit { |
There was a problem hiding this comment.
If the build does not require any special git information, it is better to use fetchFromGitLab, since that will download the src much more efficiently.
ryantm
requested changes
Jul 3, 2018
| src = fetchGit { | ||
| url = "https://gitlab.com/mildlyparallel/pscircle.git"; | ||
| rev = "3ddc37dd859472a28e2d12b518201db7793f004a"; | ||
| }; |
There was a problem hiding this comment.
This is failing to evaluate because you are missing the sha256 attribute that would make this a fixed-output derivation. Here is an example: https://github.com/NixOS/nixpkgs/blob/56904d7c423f2b13b37fbd29f39bbb4b52bc7824/pkgs/misc/gnuk/default.nix
You can get the correct sha256 attribute by running nix-prefetch-url -A pscircle.src.
|
Cheers, will fix ASAP
…On Tue, Jul 3, 2018, 04:26 Ryan Mulligan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In pkgs/os-specific/linux/pscircle/default.nix
<#42870 (comment)>:
> @@ -0,0 +1,27 @@
+{ stdenv, meson, pkgconfig, ninja, cairo
+}:
+
+stdenv.mkDerivation rec {
+ name = "pscircle-${version}";
+ version = "1.0.0";
+
+ src = fetchGit {
+ url = "https://gitlab.com/mildlyparallel/pscircle.git";
+ rev = "3ddc37dd859472a28e2d12b518201db7793f004a";
+ };
This is failing to evaluate because you are missing the sha256 attribute
that would make this a fixed-output derivation. Here is an example:
https://github.com/NixOS/nixpkgs/blob/56904d7c423f2b13b37fbd29f39bbb4b52bc7824/pkgs/misc/gnuk/default.nix
You can get the correct sha256 attribute by running nix-prefetch-url -A
pscircle.src.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42870 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACW65jlAlVKMBHR2Lb3bUYSzShpNIRWBks5uCtZkgaJpZM4U_OGE>
.
|
ryantm
requested changes
Jul 3, 2018
| url = "https://gitlab.com/mildlyparallel/pscircle.git"; | ||
| src = fetchFromGitLab { | ||
| owner = "mildlyparallel"; | ||
| repo = "pscircle"; | ||
| rev = "3ddc37dd859472a28e2d12b518201db7793f004a"; |
There was a problem hiding this comment.
please use rev = "v${version}"; because this will make it easier to update the package
|
@GrahamcOfBorg build pscircle |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: pscircle Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pscircle Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pscircle Partial log (click to expand)
|
|
Thanks for indulging with me Ryan, you've been very helpful |
|
Okay, please squash the commits into one commit with the message "pscircle: init at 1.0.0" and then it should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://gitlab.com/mildlyparallel/pscircle compiled from source
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)